Merge lp:~dandrader/qtubuntu/noQtSensors-lp1481389 into lp:qtubuntu
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Gerry Boland on 2015-08-06 | ||||
| Approved revision: | 275 | ||||
| Merged at revision: | 278 | ||||
| Proposed branch: | lp:~dandrader/qtubuntu/noQtSensors-lp1481389 | ||||
| Merge into: | lp:qtubuntu | ||||
| Diff against target: |
1165 lines (+23/-925) 22 files modified
debian/control (+0/-6) debian/copyright (+1/-5) qtubuntu.pro (+1/-1) src/ubuntumirclient/input.cpp (+5/-5) src/ubuntumirclient/integration.cpp (+6/-1) src/ubuntumirclient/orientationchangeevent_p.h (+4/-3) src/ubuntumirclient/screen.cpp (+4/-4) src/ubuntumirclient/ubuntumirclient.pro (+2/-2) tests/Application.qml (+0/-180) tests/Fullscreen.qml (+0/-43) tests/Input.qml (+0/-88) tests/InputFilter.qml (+0/-71) tests/Logo.qml (+0/-21) tests/MovingLogo.qml (+0/-73) tests/TextInput.qml (+0/-34) tests/WarpingLogo.qml (+0/-84) tests/clipboard/clipboard.cc (+0/-61) tests/clipboard/clipboard.pro (+0/-7) tests/qmlscene_ubuntu/qmlscene_ubuntu.cc (+0/-178) tests/qmlscene_ubuntu/qmlscene_ubuntu.h (+0/-36) tests/qmlscene_ubuntu/qmlscene_ubuntu.pro (+0/-12) tests/tests.pro (+0/-10) |
||||
| To merge this branch: | bzr merge lp:~dandrader/qtubuntu/noQtSensors-lp1481389 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve on 2015-08-06 | |
| Gerry Boland | Approve on 2015-08-06 | ||
| Daniel d'Andrada (community) | Approve on 2015-08-06 | ||
|
Review via email:
|
|||
Commit Message
Remove QtSensors dependency
The only thing the Mir plugin used from QtSensors was the enum
QOrientationRea
Description of the Change
Pulling the fix from https:/
| Gerry Boland (gerboland) wrote : | # |
Please remove libqt5sensors5-dev from debian/control
Also is qtdeclarative5-dev needed?
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:272
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 273. By Daniel d'Andrada on 2015-08-06
-
Remove unneeded dependencies from debian/control and ancient manual tests
| Daniel d'Andrada (dandrader) wrote : | # |
> Please remove libqt5sensors5-dev from debian/control
>
> Also is qtdeclarative5-dev needed?
Well spotted. Removed them all
| Gerry Boland (gerboland) wrote : | # |
Minor nitpick:
debian/copyright - remove reference to tests dir.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:273
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 274. By Daniel d'Andrada on 2015-08-06
-
Update debian/copyright
| Daniel d'Andrada (dandrader) wrote : | # |
On 06/08/15 13:44, Gerry Boland wrote:
> Minor nitpick:
> debian/copyright - remove reference to tests dir.
Done.
| Gerry Boland (gerboland) wrote : | # |
+QT += core-private gui-private ....
We don't need gui-private either
- 275. By Daniel d'Andrada on 2015-08-06
-
We don't need gui-private either
| Daniel d'Andrada (dandrader) wrote : | # |
On 06/08/15 14:07, Gerry Boland wrote:
> Review: Needs Fixing
>
> +QT += core-private gui-private ....
> We don't need gui-private either
Done.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:274
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://

Approving as this code is not mine and I reviewed and tested it