Code review comment for lp:~dandrader/qtmir/supportedOrientations

On 16/04/15 13:35, Michał Sawicz wrote:
>> > === modified file 'CMakeLists.txt'
>> > --- CMakeLists.txt 2015-03-18 10:12:16 +0000
>> > +++ CMakeLists.txt 2015-04-16 16:26:05 +0000
>> > @@ -79,6 +79,7 @@
>> > pkg_check_modules(LTTNG lttng-ust)
>> > pkg_check_modules(QTDBUSTEST libqtdbustest-1 REQUIRED)
>> > pkg_check_modules(QTDBUSMOCK libqtdbusmock-1 REQUIRED)
>> > +pkg_check_modules(APPLICATION_API REQUIRED unity-shell-application=6)
> This somewhat conflicts with the changes in lp:~saviq/qtmir/fix-application-api-deps...
>
It's needed when unity-api is installed somewhere other than /usr.

This pkg_check_modules call has to be in the root dir otherwise I'll have to repeat it in several test dirs in addition to src dir. Repetition is bad in my book. It gets particularly tedious when you have to bump the API number.