Merge lp:~dandrader/qtmir/resizeSuspending into lp:qtmir

Proposed by Daniel d'Andrada
Status: Merged
Approved by: Gerry Boland
Approved revision: 368
Merged at revision: 368
Proposed branch: lp:~dandrader/qtmir/resizeSuspending
Merge into: lp:qtmir
Prerequisite: lp:~dandrader/qtmir/mirSurface
Diff against target: 65 lines (+8/-33)
2 files modified
debian/changelog (+6/-32)
src/modules/Unity/Application/mirsurface.cpp (+2/-1)
To merge this branch: bzr merge lp:~dandrader/qtmir/resizeSuspending
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+269207@code.launchpad.net

Commit message

Allow resizing an app that is in the process of getting suspended.

Happens when you lock the phone while showing an app in landscape. As
the display turns off, shell rotates itself back to portrait and starts
suspending the app.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM. I'm told the merge conflict is LP being confused by the prereq

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-08-26 13:02:34 +0000
3+++ debian/changelog 2015-08-26 13:02:35 +0000
4@@ -1,4 +1,9 @@
5-<<<<<<< TREE
6+qtmir (0.4.6) UNRELEASED; urgency=medium
7+
8+ * Enable multiple MirSurfaceItems rendering the same MirSurface
9+
10+ -- Daniel d'Andrada <daniel.dandrada@canonical.com> Mon, 27 Jul 2015 13:16:20 -0300
11+
12 qtmir (0.4.5+15.10.20150817-0ubuntu1) wily; urgency=medium
13
14 *
15@@ -6,37 +11,6 @@
16 -- CI Train Bot <ci-train-bot@canonical.com> Mon, 17 Aug 2015 19:28:26 +0000
17
18 qtmir (0.4.5+15.10.20150812.1-0ubuntu1) vivid; urgency=medium
19-=======
20-qtmir (0.4.6) UNRELEASED; urgency=medium
21-
22- * Enable multiple MirSurfaceItems rendering the same MirSurface
23-
24- -- Daniel d'Andrada <daniel.dandrada@canonical.com> Mon, 27 Jul 2015 13:16:20 -0300
25-
26-qtmir (0.4.5+15.04.20150821-0ubuntu1) vivid; urgency=medium
27-
28- [ Daniel d'Andrada ]
29- * Improve handling of applications that are stopping or getting killed
30- (LP: #1483840, #1485608)
31-
32- [ Gerry Boland ]
33- * AppMan: if app destroys surface while in Running state, it is
34- probably shutting down, so preempt it by removing it from the model
35-
36- -- CI Train Bot <ci-train-bot@canonical.com> Fri, 21 Aug 2015 11:40:14 +0000
37-
38-qtmir (0.4.5+15.04.20150820-0ubuntu1) vivid; urgency=medium
39-
40- [ Gerry Boland ]
41- * Hotfix to work around bug 1483752 (LP: #1483752)
42-
43- [ Michael Zanetti ]
44- * Hotfix to work around bug 1483752 (LP: #1483752)
45-
46- -- CI Train Bot <ci-train-bot@canonical.com> Thu, 20 Aug 2015 12:59:54 +0000
47-
48-qtmir (0.4.5+15.04.20150812.1-0ubuntu1) vivid; urgency=medium
49->>>>>>> MERGE-SOURCE
50
51 [ Daniel van Vugt ]
52 * MirSurfaceItem: Remove an unnecessary and potentially infinite loop
53
54=== modified file 'src/modules/Unity/Application/mirsurface.cpp'
55--- src/modules/Unity/Application/mirsurface.cpp 2015-08-26 13:02:34 +0000
56+++ src/modules/Unity/Application/mirsurface.cpp 2015-08-26 13:02:35 +0000
57@@ -587,7 +587,8 @@
58 {
59 return (m_session &&
60 (m_session->state() == Session::State::Running
61- || m_session->state() == Session::State::Starting))
62+ || m_session->state() == Session::State::Starting
63+ || m_session->state() == Session::State::Suspending))
64 || !m_session;
65 }
66

Subscribers

People subscribed via source and target branches