Code review comment for lp:~dandrader/qtmir/dbusClipboard

Revision history for this message
Robert Carr (robertcarr) wrote :

The comments and assert at 69/70 seems a little concerning...? Perhaps the data could be clipped? (even in Clipboard::setMimeData...then the assert could remain, becoming an actual precondition of the function).

Beyond that seems ok as a temporary solution.

review: Needs Fixing

« Back to merge proposal