Merge lp:~dandrader/libindicate/plug-leak-gpropcb into lp:libindicate/0.6

Proposed by Daniel d'Andrada
Status: Superseded
Proposed branch: lp:~dandrader/libindicate/plug-leak-gpropcb
Merge into: lp:libindicate/0.6
Diff against target: 20 lines (+2/-1)
1 file modified
libindicate/listener.c (+2/-1)
To merge this branch: bzr merge lp:~dandrader/libindicate/plug-leak-gpropcb
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+92277@code.launchpad.net

This proposal has been superseded by a proposal from 2012-02-09.

Description of the change

Plug leak in get_property_cb

It would leak memory whenever an error occurs.

To post a comment you must log in.

Unmerged revisions

439. By Daniel d'Andrada

Plug leak in get_property_cb

It would leak memory whenever an error occurs.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libindicate/listener.c'
2--- libindicate/listener.c 2011-09-20 03:17:39 +0000
3+++ libindicate/listener.c 2012-02-09 14:14:24 +0000
4@@ -954,7 +954,7 @@
5 if (error != NULL) {
6 g_warning("Unable to get property data: %s", error->message);
7 g_error_free(error);
8- return;
9+ goto cleanup;
10 }
11
12 GVariant * value = g_variant_get_child_value(retvalue, 0);
13@@ -999,6 +999,7 @@
14 }
15 }
16
17+ cleanup:
18 if (retvalue != NULL) {
19 g_variant_unref(retvalue);
20 }

Subscribers

People subscribed via source and target branches