Merge lp:~dandrader/grail/start_times_growth into lp:grail

[Daniel d'Andrada]

Erase ended touches from start_times_ map. Otherwise that map will keep growing indefinitely with every new touch for no good reason.

[Stephen M. Webb (bregma)]

Fair enough.

Have you run valgrind on test cases to help identify any other leaks?

review: Approve

[Daniel d'Andrada (dandrader)]

> Fair enough.
>
> Have you run valgrind on test cases to help identify any other leaks?

No, I didn't. I found that one by reading the code.

[Chase Douglas (chasedouglas)]

Valgrind is slow enough that the test cases don't recognize gestures properly. This was as of the last time I tried. Maybe now that everything is based on X server timestamps things will work correctly.

=== modified file 'src/v3/recognizer.cpp'
--- src/v3/recognizer.cpp	2012-03-08 20:59:56 +0000
+++ src/v3/recognizer.cpp	2012-03-14 15:00:27 +0000
@@ -696,6 +696,7 @@
     }
 
     ERASE_TOUCH(touch_id, free_touches_);
+    start_times_.erase(touch_id);
 
 next_touch: ;
   }