lp:~dandrader/grail/lp949916

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:grail

Chase Douglas (community): Approve on 2012-03-14

Diff: 2681 lines (+1881/-475)

17 files modified

src/Makefile.am (+4/-0)
src/v3/atomic-recognizer.cpp (+308/-0)
src/v3/atomic-recognizer.h (+52/-0)
src/v3/forward.h (+14/-1)
src/v3/gesture.cpp (+39/-1)
src/v3/gesture.h (+5/-0)
src/v3/handle.cpp (+29/-5)
src/v3/handle.h (+1/-0)
src/v3/log.cpp (+4/-0)
src/v3/log.h (+4/-0)
src/v3/recognizer.cpp (+11/-453)
src/v3/recognizer.h (+33/-15)
src/v3/regular-recognizer.cpp (+396/-0)
src/v3/regular-recognizer.h (+52/-0)
test/Makefile.am (+1/-0)
test/recordings/apple-wtrackpad-synced-4-drag.event (+713/-0)
test/x11/no-premature-gestures.cpp (+215/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #949916: N-touch Touch gestures come even when actual number of touches is > N

High

Fix Released

Link a bug report

Related blueprints

199. By Daniel d'Andrada on 2012-03-14

Regression test for lp:949916

Check that, when using atomic gestures, we don't get
premature slices of 2 or 3 touches when a roughly synced 4-fingers'
gesture is performed.

198. By Daniel d'Andrada on 2012-03-14

Atomic rules: Don't send slices from premature gestures. (lp:949916)

Wait a bit until accepting a gesture to avoid premature gestures that
will immediately get cancelled due to the apparition of a new touch
point on the following events.
e.g. like when a user puts four fingers on a touch screen but
the corresponding touch points come in separate events (because fingers
don't land precisely in sync and/or UTouch frame doesn't process their
arrivals in the very same event). We should generate only the "final"
4-touches' gesture and not the intermediates 2-touches and 3-touches
gestures.

197. By Daniel d'Andrada on 2012-03-14

Refactoring v3/Recognizer. Split into Regular and Atomic recognizers

Instead of having many "if (atomic_)" sprinkled throughout the code, have
two recognizers: of for atomic gesture rules and another for regular rules.

That will also make the atomic gestures code flow easier to understand and
tune. Likewise for regular rules.

196. By Daniel d'Andrada on 2012-03-14

Merged "Erase ended touches from start_times_ map"

195. By Daniel d'Andrada on 2012-03-12

Merge "A touch cannot be accepted and unaccepted simultaneously."

194. By Daniel d'Andrada on 2012-03-09

Updated .bzrignore

193. By Daniel d'Andrada on 2012-03-06

Release version 3.0.2

192. By Daniel d'Andrada on 2012-03-06

Merge fix for bugs Tap recognition

191. By Jussi Pakkanen on 2012-03-06

Merged compile/link tests.

190. By Chase Douglas on 2012-02-20

Merge fix for touch grab failure checks