Code review comment for lp:~danci-emanuel/mailman/messages_support
Revision history for this message
| Emanuel Danci (danci-emanuel) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
357f4db
(Get the code!)
Just some small comments:
1. This is only the part that will be used by the handlers when creating the new messags. (the equivalent of the Message class from DlistUtils)
2. I did not push the code for the other parts of the DlistUtils (the ones related to the Thread and Override classes) because I still have to finish some parts of them and I also took you advice, pushing smaller pieces of code, so that they will be easier to review.
3. I also changed the attribute from mailinglist.py, the one that you told me to, and added the missing line to max_size.py.
4. I tried to add Terri as I reviewer to, but I cannot seem to find her on launchpad.