Code review comment for lp:~danci-emanuel/mailman/dlists_support_added

Robin J (robin-jeffries) wrote :

This all looks reasonable, but I don't have the larger context of what these files are actually doing.

At line 114, why did you delete mlist.advertised?

It also looks like you are arbitrarily changing the indentation at lines 44 and 82. That's not good.

With those changes, it's probably OK for now. (you need a larger context to be able to test it, I think -- like something that uses the dlists_enabled variable?

review: Approve

« Back to merge proposal