Code review comment for lp:~damiannohales/plank/window-border-margin

Revision history for this message
Damián Nohales (damiannohales) wrote :

> Do not trigger setting the struts unconditionally.
> TopMargin should taken into account as follow:
> * only in case of HideMode==HideType.NONE
> * ignore it for non-compositing, so there is no "spacing"
> if the (solid) background covers the item-regions
> * don't have it influence the cursor-region or item-regions
> Please rebase it on the current trunk.

I think a don't understand the 3rd point, could you explain?

« Back to merge proposal