Code review comment for lp:~damiannohales/plank/window-border-margin

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Do not trigger setting the struts unconditionally.

TopMargin should taken into account as follow:
* only in case of HideMode==HideType.NONE
* ignore it for non-compositing, so there is no "spacing"
  if the (solid) background covers the item-regions
* don't have it influence the cursor-region or item-regions

Please rebase it on the current trunk.

review: Needs Fixing

« Back to merge proposal