Code review comment for lp:~damiannohales/plank/window-border-margin

Revision history for this message
Damián Nohales (damiannohales) wrote :

> This sounds reasonable if a theme defines a negative TopPadding. Considering
> that this should be a parameter in *dock.theme* not in settings. ;-)
> So please move it to DockTheme as TopMargin. You should be able to contain the
> needed changes to DockTheme.vala, DockPreferences.vala and
> PositionManager.vala.

You are describing my first try when implementing this :P

I changed it to a setting because the plank settings also defines "outside" alignment stuff, but is ok, let's move it to the theme.

« Back to merge proposal