Code review comment for lp:~damiannohales/plank/window-border-margin

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

This sounds reasonable if a theme defines a negative TopPadding. Considering that this should be a parameter in *dock.theme* not in settings. ;-)

So please move it to DockTheme as TopMargin. You should be able to contain the needed changes to DockTheme.vala, DockPreferences.vala and PositionManager.vala.

review: Needs Fixing

« Back to merge proposal