Merge lp:~daker/webbrowser-app/fix.1328183-twitter into lp:webbrowser-app
Proposed by
Adnane Belmadiaf
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~daker/webbrowser-app/fix.1328183-twitter | ||||
Merge into: | lp:webbrowser-app | ||||
Diff against target: |
10 lines (+2/-0) 1 file modified
src/Ubuntu/Web/ua-overrides-mobile.js (+2/-0) |
||||
To merge this branch: | bzr merge lp:~daker/webbrowser-app/fix.1328183-twitter | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Phablet Team | Pending | ||
Review via email: mp+223172@code.launchpad.net |
Commit message
Fixed UA override for twitter
To post a comment you must log in.
Unmerged revisions
- 569. By Adnane Belmadiaf
-
Fixed UA override for twitter
Does that change fix an issue?
Otherwise, since the override applies only when executed on mobile devices, I think it makes sense to send a different mobile UA on all of twitter. This way, if someone goes to twitter.com, he would still do so with the overriden UA.
What do you think?