Merge lp:~daker/webbrowser-app/fix.1169758 into lp:webbrowser-app

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 325
Merged at revision: 335
Proposed branch: lp:~daker/webbrowser-app/fix.1169758
Merge into: lp:webbrowser-app
Diff against target: 60 lines (+40/-0)
2 files modified
src/app/Browser.qml (+2/-0)
src/app/ConfirmDialog.qml (+38/-0)
To merge this branch: bzr merge lp:~daker/webbrowser-app/fix.1169758
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
Review via email: mp+186892@code.launchpad.net

Commit message

Added support for confirm dialogs

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks great!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~daker/webbrowser-app/fix.1169758 updated
325. By Adnane Belmadiaf

Merged trunk
Fixed merge conflicts

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/Browser.qml'
2--- src/app/Browser.qml 2013-09-24 09:43:09 +0000
3+++ src/app/Browser.qml 2013-09-24 10:11:38 +0000
4@@ -346,10 +346,12 @@
5 devicePixelRatio: browser.qtwebkitdpr
6
7 experimental.preferences.developerExtrasEnabled: browser.developerExtrasEnabled
8+
9 experimental.certificateVerificationDialog: CertificateVerificationDialog { }
10 experimental.authenticationDialog: AuthenticationDialog {}
11 experimental.proxyAuthenticationDialog: ProxyAuthenticationDialog {}
12 experimental.alertDialog: AlertDialog { }
13+ experimental.confirmDialog: ConfirmDialog { }
14
15 selectionActions: ActionList {
16 Action {
17
18=== added file 'src/app/ConfirmDialog.qml'
19--- src/app/ConfirmDialog.qml 1970-01-01 00:00:00 +0000
20+++ src/app/ConfirmDialog.qml 2013-09-24 10:11:38 +0000
21@@ -0,0 +1,38 @@
22+/*
23+ * Copyright 2013 Canonical Ltd.
24+ *
25+ * This file is part of webbrowser-app.
26+ *
27+ * webbrowser-app is free software; you can redistribute it and/or modify
28+ * it under the terms of the GNU General Public License as published by
29+ * the Free Software Foundation; version 3.
30+ *
31+ * webbrowser-app is distributed in the hope that it will be useful,
32+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
33+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
34+ * GNU General Public License for more details.
35+ *
36+ * You should have received a copy of the GNU General Public License
37+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
38+ */
39+
40+import QtQuick 2.0
41+import Ubuntu.Components 0.1
42+import Ubuntu.Components.Popups 0.1 as Popups
43+
44+Popups.Dialog {
45+ title: i18n.tr("JavaScript Confirmation")
46+ text: model.message
47+
48+ Button {
49+ text: i18n.tr("OK")
50+ onClicked: model.accept()
51+ }
52+
53+ Button {
54+ text: i18n.tr("Cancel")
55+ onClicked: model.reject()
56+ }
57+
58+ Component.onCompleted: show()
59+}
60\ No newline at end of file

Subscribers

People subscribed via source and target branches

to status/vote changes: