Merge lp:~daker/webbrowser-app/fix.1169757 into lp:webbrowser-app

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 325
Merged at revision: 326
Proposed branch: lp:~daker/webbrowser-app/fix.1169757
Merge into: lp:webbrowser-app
Diff against target: 50 lines (+34/-0)
2 files modified
src/app/AlertDialog.qml (+33/-0)
src/app/Browser.qml (+1/-0)
To merge this branch: bzr merge lp:~daker/webbrowser-app/fix.1169757
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
Review via email: mp+186925@code.launchpad.net

Commit message

Added support for Alert dialogs

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks great!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'src/app/AlertDialog.qml'
2--- src/app/AlertDialog.qml 1970-01-01 00:00:00 +0000
3+++ src/app/AlertDialog.qml 2013-09-21 19:57:28 +0000
4@@ -0,0 +1,33 @@
5+/*
6+ * Copyright 2013 Canonical Ltd.
7+ *
8+ * This file is part of webbrowser-app.
9+ *
10+ * webbrowser-app is free software; you can redistribute it and/or modify
11+ * it under the terms of the GNU General Public License as published by
12+ * the Free Software Foundation; version 3.
13+ *
14+ * webbrowser-app is distributed in the hope that it will be useful,
15+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
16+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17+ * GNU General Public License for more details.
18+ *
19+ * You should have received a copy of the GNU General Public License
20+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
21+ */
22+
23+import QtQuick 2.0
24+import Ubuntu.Components 0.1
25+import Ubuntu.Components.Popups 0.1 as Popups
26+
27+Popups.Dialog {
28+ title: i18n.tr("JavaScript Alert")
29+ text: model.message
30+
31+ Button {
32+ text: i18n.tr("OK")
33+ onClicked: model.dismiss()
34+ }
35+
36+ Component.onCompleted: show()
37+}
38\ No newline at end of file
39
40=== modified file 'src/app/Browser.qml'
41--- src/app/Browser.qml 2013-09-19 19:39:50 +0000
42+++ src/app/Browser.qml 2013-09-21 19:57:28 +0000
43@@ -346,6 +346,7 @@
44 devicePixelRatio: browser.qtwebkitdpr
45
46 experimental.preferences.developerExtrasEnabled: browser.developerExtrasEnabled
47+ experimental.alertDialog: AlertDialog { }
48
49 selectionActions: ActionList {
50 Action {

Subscribers

People subscribed via source and target branches

to status/vote changes: