Merge lp:~daker/ubuntu-ui-toolkit/fix.1665944 into lp:ubuntu-ui-toolkit/staging
| Status: | Merged |
|---|---|
| Approved by: | Christian Dywan on 2017-02-21 |
| Approved revision: | 2174 |
| Merged at revision: | 2178 |
| Proposed branch: | lp:~daker/ubuntu-ui-toolkit/fix.1665944 |
| Merge into: | lp:ubuntu-ui-toolkit/staging |
| Diff against target: |
13 lines (+2/-1) 1 file modified
src/imports/Components/ListItems/1.3/LabelVisual.qml (+2/-1) |
| To merge this branch: | bzr merge lp:~daker/ubuntu-ui-toolkit/fix.1665944 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve on 2017-02-21 | |
| Christian Dywan | 2017-02-19 | Approve on 2017-02-21 | |
|
Review via email:
|
|||
Commit Message
Fix ListItem title/subtitle alignment & elide in RTL mode
Description of the Change
Fix ListItem title/subtitle alignment & elide in RTL mode
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2174
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
I'm not entirely sure setting horizontalAlignment here is correct - but I'm prepared to accept it as-is and revisit it later if need be, I don't expect it to have other side effects.