Ubuntu UI Toolkit

Merge lp:~daker/ubuntu-ui-toolkit/fix.1664758 into lp:ubuntu-ui-toolkit/staging

  1. fix.1664758
  2. Merge into staging
Proposed by Adnane Belmadiaf on 2017-02-15
Status: Merged
Approved by: Christian Dywan on 2017-02-15
Approved revision: 2172
Merged at revision: 2172
Proposed branch: lp:~daker/ubuntu-ui-toolkit/fix.1664758
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 12 lines (+1/-1)
1 file modified
src/imports/Components/1.3/ListItemPopover.qml (+1/-1)
To merge this branch: bzr merge lp:~daker/ubuntu-ui-toolkit/fix.1664758
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve on 2017-02-15
Christian Dywan 2017-02-15 Approve on 2017-02-15
Review via email: mp+317307@code.launchpad.net

Commit Message

Replace the hardcoded color with a theme color

Description of the Change

Replace the hardcoded color with a theme color

To post a comment you must log in.
Christian Dywan (kalikiana) wrote :

Good catch! Thanks a lot!

review: Approve
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/imports/Components/1.3/ListItemPopover.qml'
2--- src/imports/Components/1.3/ListItemPopover.qml 2015-07-01 12:06:34 +0000
3+++ src/imports/Components/1.3/ListItemPopover.qml 2017-02-15 12:01:57 +0000
4@@ -35,7 +35,7 @@
5 Label {
6 anchors.verticalCenter: parent.verticalCenter
7 text: action.text
8- color: '#5D5D5D'
9+ color: theme.palette.normal.backgroundText
10 }
11
12 onClicked: popover.hide()

Subscribers

People subscribed via source and target branches