Merge lp:~daker/ubuntu-ui-toolkit/fix.1630872 into lp:ubuntu-ui-toolkit/staging
| Status: | Merged |
|---|---|
| Approved by: | Christian Dywan on 2017-02-21 |
| Approved revision: | 2175 |
| Merged at revision: | 2179 |
| Proposed branch: | lp:~daker/ubuntu-ui-toolkit/fix.1630872 |
| Merge into: | lp:ubuntu-ui-toolkit/staging |
| Diff against target: |
17 lines (+6/-1) 1 file modified
src/imports/Components/1.3/TextField.qml (+6/-1) |
| To merge this branch: | bzr merge lp:~daker/ubuntu-ui-toolkit/fix.1630872 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve on 2017-02-21 | |
| Christian Dywan | 2017-02-21 | Approve on 2017-02-21 | |
|
Review via email:
|
|||
Commit Message
Make sure we resets partial text input from the input method
Description of the Change
Clear method has been in Qt 5.7 so for now we need to reset the input method & put an empty string to clear the input field
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
FAILED: Autolanding.
More details in the following jenkins job:
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
FAILURE: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:2175
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
Good catch, I wasn't aware of this. And good call on the FIXME. Good to go!