Merge lp:~daker/ubuntu-system-settings/fix.brightness.slider into lp:ubuntu-system-settings

[Adnane Belmadiaf]

Live change the brightness to much the panel indicator

[Omer Akram (om26er)]

LGTM

review: Approve

[Matthew Paul Thomas (mpt)]

This is implicit in anything I design, but I've now mentioned it explicitly: "Unless specifically noted, all interface elements in System Settings should update live to reflect settings when they are changed elsewhere." <https://wiki.ubuntu.com/SystemSettings?action=diff&rev2=53&rev1=52>

review: Approve (design)

[Matthew Paul Thomas (mpt)]

And thanks for the fix, Adnane!

[Iain Lane (laney)]

On Mon, Dec 16, 2013 at 09:57:05AM -0000, Matthew Paul Thomas wrote:
> Review: Approve design
>
> This is implicit in anything I design, but I've now mentioned it explicitly: "Unless specifically noted, all interface elements in System Settings should update live to reflect settings when they are changed elsewhere." <https://wiki.ubuntu.com/SystemSettings?action=diff&rev2=53&rev1=52>

You're talking about something different to what this change achieves -
this is about updating the brightness while you're dragging the slider,
rather than just when you release it.

  http://developer.ubuntu.com/api/qml/sdk-1.0/Ubuntu.Components.Slider/#live-prop

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Adnane Belmadiaf (daker)]

Hi Iain, juste open the battery indicator, slide the brightness slider, the change is live.

[Iain Lane (laney)]

On Mon, Dec 16, 2013 at 11:37:33AM -0000, Adnane Belmadiaf wrote:
> Hi Iain, juste open the battery indicator, slide the brightness slider, the change is live.

I know, I was responding to Matthew.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Iain Lane (laney)]

Checked, works fine. Thanks. :-)

review: Approve

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

[Matthew Paul Thomas (mpt)]

Sorry for the misunderstanding. I think live live updating is a good default for sliders too.

=== modified file 'plugins/battery/PageComponent.qml'
--- plugins/battery/PageComponent.qml	2013-12-03 16:58:58 +0000
+++ plugins/battery/PageComponent.qml	2013-12-13 17:17:50 +0000
@@ -277,6 +277,7 @@
                         maximumValue: 100.0
                         enabled: indicatorPower.brightness.state != null
                         value: enabled ? indicatorPower.brightness.state * 100 : 0.0
+                        live: true
 
                         onValueChanged: indicatorPower.brightness.updateState(value / 100.0);
                     }