Merge lp:~daker/ubuntu-html5-theme/fix.1241215 into lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Kyle Nitzsche
Approved revision: 90
Merged at revision: 88
Proposed branch: lp:~daker/ubuntu-html5-theme/fix.1241215
Merge into: lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance
Diff against target: 12 lines (+1/-1)
1 file modified
0.1/ambiance/js/list.js (+1/-1)
To merge this branch: bzr merge lp:~daker/ubuntu-html5-theme/fix.1241215
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Kyle Nitzsche Approve
Adnane Belmadiaf Needs Resubmitting
Review via email:

Commit message

Spaces instead of tabs

To post a comment you must log in.
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

This MR shows changes on almost every line since it also appears to contain the fix for (some js files use tabs, others spaces for indentation).

Adnane, would you prefer to modify this branch to fix only the List.remove() bug?

89. By Adnane Belmadiaf

Reverted tab to space change

90. By Adnane Belmadiaf


Revision history for this message
Adnane Belmadiaf (daker) wrote :


review: Needs Resubmitting
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Can you please top-approve this first so i can fix this MR ?

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :


review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '0.1/ambiance/js/list.js'
2--- 0.1/ambiance/js/list.js 2013-07-17 15:27:43 +0000
3+++ 0.1/ambiance/js/list.js 2013-10-21 14:03:41 +0000
4@@ -130,7 +130,7 @@
5 remove: function (index) {
6 var item =;
7 if (item) {
8- item.parendNode.removeChild(item);
9+ item.parentNode.removeChild(item);
10 }
11 },
12 /*


People subscribed via source and target branches