Merge lp:~daker/loco-team-portal/fix.approved into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Michael Hall
Approved revision: 661
Merged at revision: 660
Proposed branch: lp:~daker/loco-team-portal/fix.approved
Merge into: lp:loco-team-portal
Diff against target: 115 lines (+21/-14)
4 files modified
loco_directory/media/css/styles.css (+2/-0)
loco_directory/teams/views.py (+3/-0)
loco_directory/templates/teams/team_reapprovals.html (+13/-13)
loco_directory/urls.py (+3/-1)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.approved
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+193170@code.launchpad.net

Commit message

Fixed "Teams Re-verifications" page

To post a comment you must log in.
661. By Adnane Belmadiaf

Uncommited changes

Revision history for this message
Michael Hall (mhall119) wrote :

Looks good, tests all pass.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/media/css/styles.css'
2--- loco_directory/media/css/styles.css 2013-09-04 22:35:30 +0000
3+++ loco_directory/media/css/styles.css 2013-10-30 00:43:51 +0000
4@@ -62,10 +62,12 @@
5
6 li.approved {
7 list-style-image: url(../img/approved.png); /* Colorful Ubuntu Logo */
8+ text-align: left;
9 }
10
11 li.unapproved {
12 list-style-image: url(../img/unapproved.png); /* Grey Ubuntu Logo */
13+ text-align: left;
14 }
15
16 .relative {
17
18=== modified file 'loco_directory/teams/views.py'
19--- loco_directory/teams/views.py 2013-02-19 22:23:46 +0000
20+++ loco_directory/teams/views.py 2013-10-30 00:43:51 +0000
21@@ -22,6 +22,9 @@
22
23
24 def reapprovals(request):
25+ return redirect('/loco-council/verified/')
26+
27+def verified(request):
28 teams = filter(lambda a: a.approved and a.expires_date != None,
29 Team.objects.all().order_by('expires_date', 'name'))
30 today = datetime.date.today()
31
32=== modified file 'loco_directory/templates/teams/team_reapprovals.html'
33--- loco_directory/templates/teams/team_reapprovals.html 2012-06-02 11:50:27 +0000
34+++ loco_directory/templates/teams/team_reapprovals.html 2013-10-30 00:43:51 +0000
35@@ -1,44 +1,44 @@
36 {% extends "base.html" %}
37 {% load i18n %}
38
39-{% block page_name %}{% trans "Approved Ubuntu LoCo Teams" %}{% endblock %}
40+{% block page_name %}{% trans "Verified Ubuntu LoCo Teams" %}{% endblock %}
41
42 {% block extrahead %}{{ block.super }}{% endblock %}
43
44 {% block content %}
45 <div class="row">
46 <section class="span-12">
47-<h1>{% trans "Approved Ubuntu LoCo Teams" %}</h1>
48+<h1>{% trans "Verified Ubuntu LoCo Teams" %}</h1>
49 </section>
50 </div>
51 <div class="row">
52-<section class="span-8">
53+<section class="span-12">
54 {% with '</a>' as end_link %}
55 {% with '<a href="https://wiki.ubuntu.com/LoCoGettingApproved">' as approved_link %}
56 {% with '<a href="https://wiki.ubuntu.com/LoCoFAQ">' as faq_link %}
57 {% with '<a href="https://wiki.ubuntu.com/LoCoCouncil/LoCoTeamReApproval">' as reapprove_link %}
58
59- <h2>{% trans "Getting Your Team Approved" %}</h2>
60+ <h2>{% trans "Getting Your Team Verified" %}</h2>
61 <p>{% trans "Ubuntu LoCo teams fall into two approximate categories:" %}
62 <ul>
63 <li>{% trans "New Teams - these are teams that are in the process of getting started and have not yet been officially approved as an Ubuntu LoCo team." %}</li>
64- <li>{% trans "Approved Teams - an approved team is a team that is up and running, has each of the required resources in operation and the team is working well." %}</li>
65+ <li>{% trans "Verified Teams - a verified team is a team that is up and running, has each of the required resources in operation and the team is working well." %}</li>
66 </ul>
67 </p>
68- <p>{% blocktrans %}For more information on getting approved, you can look at {{ approved_link }}getting your LoCo team approved{{ end_link }} and the {{ faq_link }}LoCo Team FAQs{{ end_link }} pages created by the LoCo Council.{% endblocktrans %}</p>
69- <h2>{% trans "Getting Your Team Reapproved" %}</h2>
70- <p>{% trans "Every two years each LoCo team must be reapproved. LoCo teams will be contacted by a member of the LoCo Council notifying the team that it is time for them to be reapproved. The LoCo team then will need to create an application, much like the initial approval application showing that they have been active in the community in the past two years." %}</p>
71- <p>{% blocktrans %}For more information on getting reapproved, the LoCo Council has created the {{ reapprove_link }}LoCo Team Reapproval{{ end_link }} page.{% endblocktrans %}</p>
72+ <p>{% blocktrans %}For more information on getting verified, you can look at {{ approved_link }}getting your LoCo team approved{{ end_link }} and the {{ faq_link }}LoCo Team FAQs{{ end_link }} pages created by the LoCo Council.{% endblocktrans %}</p>
73+ <h2>{% trans "Getting Your Team Verified" %}</h2>
74+ <p>{% trans "Every two years each LoCo team must be verified. LoCo teams will be contacted by a member of the LoCo Council notifying the team that it is time for them to be Re-verified. The LoCo team then will need to create an application, much like the initial verification application showing that they have been active in the community in the past two years." %}</p>
75+ <p>{% blocktrans %}For more information on getting verified, the LoCo Council has created the {{ reapprove_link }}LoCo Team Verification{{ end_link }} guidelines.{% endblocktrans %}</p>
76 {% endwith %}
77 {% endwith %}
78 {% endwith %}
79 {% endwith %}
80 </section>
81-<section class="span-4 last">
82- <h2>{% trans "Approved Teams:" %}</h2>
83+<section class="span-12">
84+ <h2>{% trans "Verified Teams:" %}</h2>
85 <br />
86 {% if next_teams %}
87- <h3>{% trans "Reapprovals in the next 6 months:" %}</h3>
88+ <h3>{% trans "Re-Verifications in the next 6 months:" %}</h3>
89 <table width="100%">
90 <tr>
91 <td width="100%" valign="top" class="col2_container">
92@@ -54,7 +54,7 @@
93
94 {% if later_teams %}
95 <br />
96- <h3>{% trans "Reapprovals later on:" %}</h3>
97+ <h3>{% trans "Re-Verifications later on:" %}</h3>
98 <table width="100%">
99 <tr>
100 <td width="100%" valign="top" class="col2_container">
101
102=== modified file 'loco_directory/urls.py'
103--- loco_directory/urls.py 2013-02-16 18:50:41 +0000
104+++ loco_directory/urls.py 2013-10-30 00:43:51 +0000
105@@ -35,7 +35,9 @@
106 url(r'^meetings/', include('meetings.urls')),
107 url(r'^loco-council/$', 'teams.views.loco_council', name='loco_council'),
108 url(r'^loco-council/edit$', 'teams.views.loco_council_edit', name='lc_edit'),
109- url(r'^loco-council/approved$', 'teams.views.reapprovals', name='reapprovals'),
110+ url(r'^loco-council/approved/$', 'teams.views.reapprovals', name='reapprovals-old'),
111+ url(r'^loco-council/verified/$', 'teams.views.verified', name='reapprovals'),
112+
113 url(r'^logout$', 'common.views.site_logout', name='logout'),
114 url(r'^jsi18n', 'django.views.i18n.javascript_catalog', name='jsi18n'),
115 url(r'^services/', include('services.urls')),

Subscribers

People subscribed via source and target branches