Merge lp:~daker/loco-team-portal/fix.960695.events-app into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 570
Merged at revision: 570
Proposed branch: lp:~daker/loco-team-portal/fix.960695.events-app
Merge into: lp:loco-team-portal
Diff against target: 221 lines (+35/-35)
7 files modified
loco_directory/events/admin.py (+2/-1)
loco_directory/events/feeds.py (+8/-6)
loco_directory/events/forms.py (+2/-2)
loco_directory/events/models.py (+1/-1)
loco_directory/events/tests.py (+5/-3)
loco_directory/events/urls.py (+1/-0)
loco_directory/events/views.py (+16/-22)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.960695.events-app
Reviewer Review Type Date Requested Status
LoCo Team Portal Developers Pending
Review via email: mp+138023@code.launchpad.net

Commit message

Pep8 fixes for the events app

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/events/admin.py'
2--- loco_directory/events/admin.py 2009-12-21 20:45:43 +0000
3+++ loco_directory/events/admin.py 2012-12-04 22:33:21 +0000
4@@ -1,5 +1,6 @@
5+# -*- coding: utf-8 -*-
6 from django.contrib import admin
7-from events.models import *
8+from .models import *
9
10 admin.site.register(Venue)
11 admin.site.register(GlobalEvent)
12
13=== modified file 'loco_directory/events/feeds.py'
14--- loco_directory/events/feeds.py 2012-11-26 23:07:59 +0000
15+++ loco_directory/events/feeds.py 2012-12-04 22:33:21 +0000
16@@ -1,12 +1,14 @@
17-from django.core.exceptions import ObjectDoesNotExist
18+# -*- coding: utf-8 -*-
19 from django.core.urlresolvers import reverse
20 from django.contrib.syndication.feeds import Feed, FeedDoesNotExist
21 from django.utils.translation import ugettext as _
22-from events.models import TeamEvent, GlobalEvent
23+
24 from teams.models import Team
25+from .models import TeamEvent, GlobalEvent
26
27 import datetime
28
29+
30 class TeamEventFeed(Feed):
31 def get_object(self, bits):
32 if len(bits) >= 1:
33@@ -16,15 +18,15 @@
34 try:
35 return Team.objects.get(lp_name=bits[0])
36 except:
37- raise ObjectDoesNotExist
38+ raise FeedDoesNotExist
39 return None
40-
41+
42 def items(self, obj):
43 if isinstance(obj, Team):
44 return TeamEvent.objects.filter(teams=obj, date_end__gt=datetime.datetime.now()).order_by('-date_begin')[:15]
45 else:
46 return TeamEvent.objects.filter(date_end__gt=datetime.datetime.now()).order_by('-date_begin')[:15]
47-
48+
49 def title(self, obj):
50 if isinstance(obj, Team):
51 return _('Upcoming Events for %(teamname)s' % {'teamname': obj.name})
52@@ -44,7 +46,7 @@
53 return GlobalEvent.objects.filter(teamevent__teams=obj, date_end__gt=datetime.datetime.now()).order_by('-date_begin')[:15]
54 else:
55 return GlobalEvent.objects.filter(date_end__gt=datetime.datetime.now()).order_by('-date_begin')[:15]
56-
57+
58 def title(self, obj):
59 if isinstance(obj, Team):
60 return _('Upcoming Global Events where %(teamname)s is participating' % {'teamname': obj.name})
61
62=== modified file 'loco_directory/events/forms.py'
63--- loco_directory/events/forms.py 2012-07-14 20:07:11 +0000
64+++ loco_directory/events/forms.py 2012-12-04 22:33:21 +0000
65@@ -1,16 +1,16 @@
66 # -*- coding: utf-8 -*-
67-
68 from django import forms
69 from django.utils.translation import ugettext as _
70 from django.core.urlresolvers import reverse
71
72-from models import BaseEvent, GlobalEvent, TeamEvent, Attendee, TeamEventComment
73+from .models import BaseEvent, GlobalEvent, TeamEvent, Attendee, TeamEventComment
74 from venues.models import Venue
75 from common.forms import RenderableMixin
76 from userprofiles.models import UserProfile
77
78 import itertools
79
80+
81 def grouped_user_list(teams):
82 other_members, team_members = [], []
83 for profile in UserProfile.objects.filter(user__groups__name__in=[t.lp_name for t in teams]):
84
85=== modified file 'loco_directory/events/models.py'
86--- loco_directory/events/models.py 2012-12-03 22:19:34 +0000
87+++ loco_directory/events/models.py 2012-12-04 22:33:21 +0000
88@@ -9,7 +9,7 @@
89 from common.shortcuts import queryset_sum, queryset_count
90 from common.mixins import LocalTimeMixin
91
92-from managers import GlobalEventManager, TeamEventManager
93+from .managers import GlobalEventManager, TeamEventManager
94
95 ATTENDEE_PROMISE_CHOICES = (
96 ('sure', _('attending')),
97
98=== modified file 'loco_directory/events/tests.py'
99--- loco_directory/events/tests.py 2012-06-30 23:44:14 +0000
100+++ loco_directory/events/tests.py 2012-12-04 22:33:21 +0000
101@@ -1,16 +1,18 @@
102+# -*- coding: utf-8 -*-
103 """
104 This file demonstrates two different styles of tests (one doctest and one
105 unittest). These will both pass when you run "manage.py test".
106
107 Replace these with more appropriate tests for your application.
108 """
109-import datetime
110-
111 from django.test import TestCase
112 from django.contrib.auth.models import User, Group
113+
114 from teams.models import Country, Team
115 from venues.models import Venue
116-from events.models import TeamEvent
117+from .models import TeamEvent
118+
119+import datetime
120
121
122 class FormTests(TestCase):
123
124=== modified file 'loco_directory/events/urls.py'
125--- loco_directory/events/urls.py 2012-11-28 00:46:29 +0000
126+++ loco_directory/events/urls.py 2012-12-04 22:33:21 +0000
127@@ -1,3 +1,4 @@
128+# -*- coding: utf-8 -*-
129 from django.conf.urls.defaults import *
130
131 urlpatterns = patterns('',
132
133=== modified file 'loco_directory/events/views.py'
134--- loco_directory/events/views.py 2012-11-28 00:46:29 +0000
135+++ loco_directory/events/views.py 2012-12-04 22:33:21 +0000
136@@ -1,3 +1,4 @@
137+# -*- coding: utf-8 -*-
138 from django.template import RequestContext
139 from django.http import HttpResponse, HttpResponseRedirect, Http404
140 from django.shortcuts import render_to_response, redirect, get_object_or_404
141@@ -6,15 +7,11 @@
142 from django.utils.translation import ugettext as _
143 from django.db.models import Count
144
145-from events.models import TeamEvent
146-from events.models import GlobalEvent
147+from .models import (TeamEvent, GlobalEvent, Attendee, TeamEventComment)
148 from teams.models import Team, Country, Continent
149-from events.models import Attendee, TeamEventComment
150
151-from forms import TeamEventForm
152-from forms import TeamEventCommentForm
153-from forms import GlobalEventForm
154-from forms import AttendeeRegistrationForm
155+from .forms import (TeamEventForm, TeamEventCommentForm,
156+ GlobalEventForm, AttendeeRegistrationForm)
157
158 from common.utils import simple_iterator
159 from common.forms import FilterHistoryList
160@@ -548,24 +545,18 @@
161
162
163 def global_jam(request):
164- try:
165- global_event_object = GlobalEvent.objects.filter(name='Ubuntu Global Jam').order_by('-date_begin')[0]
166- except IndexError:
167- raise Http404
168+ global_event_object = get_list_or_404(GlobalEvent.objects.order_by('-date_begin'), name='Ubuntu Global Jam')[0]
169 return global_event_detail(request, global_event_object.id)
170
171
172 def global_jam_dashboard(request):
173- try:
174- global_event_object = GlobalEvent.objects.filter(name='Ubuntu Global Jam').order_by('-date_begin')[0]
175- except IndexError:
176- raise Http404
177-
178+ global_event_object = get_list_or_404(GlobalEvent.objects.order_by('-date_begin'), name='Ubuntu Global Jam')[0]
179 context = {
180 'global_event_object': global_event_object,
181 }
182 return render_to_response('events/global_jam_dashboard.html', context, RequestContext(request))
183
184+
185 @login_required
186 def team_event_comment_edit(request):
187 """
188@@ -583,15 +574,16 @@
189 comment_obj.save()
190 response_dict.update({'success': True, 'response': comment_obj.comment})
191 else:
192- response_dict.update({'success': False, 'response': _('Your are not authorized to edit this comment.') })
193+ response_dict.update({'success': False, 'response': _('Your are not authorized to edit this comment.')})
194 except TeamEventComment.DoesNotExist:
195- response_dict.update({'success': False, 'response': _('This comment does not exist.') })
196+ response_dict.update({'success': False, 'response': _('This comment does not exist.')})
197 else:
198- response_dict.update({'success': False, 'response': _('Missing arguments.') })
199+ response_dict.update({'success': False, 'response': _('Missing arguments.')})
200 else:
201- response_dict.update({'success': False, 'response': _('You can\'t edit this comment using this method.') })
202+ response_dict.update({'success': False, 'response': _('You can\'t edit this comment using this method.')})
203 return HttpResponse(simplejson.dumps(response_dict), mimetype='application/json')
204
205+
206 @login_required
207 def team_event_comment_delete(request, pk):
208 """
209@@ -602,8 +594,10 @@
210 if comment.commenter_profile.user == request.user:
211 comment.delete()
212 request.user.message_set.create(message=_('Your comment has been removed.'))
213- if next: redirect_to = next
214- else: redirect_to = '/'
215+ if next:
216+ redirect_to = next
217+ else:
218+ redirect_to = '/'
219 return redirect(redirect_to)
220 else:
221 raise Http404

Subscribers

People subscribed via source and target branches