Merge lp:~daker/loco-team-portal/fix.707123 into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Adnane Belmadiaf
Approved revision: 640
Merged at revision: 640
Proposed branch: lp:~daker/loco-team-portal/fix.707123
Merge into: lp:loco-team-portal
Diff against target: 103 lines (+21/-12)
5 files modified
loco_directory/meetings/urls.py (+1/-0)
loco_directory/meetings/views.py (+18/-8)
loco_directory/templates/meetings/agenda_item_update.html (+1/-0)
loco_directory/templates/meetings/team_meeting_detail.inc.html (+0/-3)
loco_directory/templates/meetings/team_meeting_detail_agenda.inc.html (+1/-1)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.707123
Reviewer Review Type Date Requested Status
LoCo Team Portal Developers Pending
Review via email: mp+158827@code.launchpad.net

Commit message

Fixed bug 707123, props svwilliams

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/meetings/urls.py'
2--- loco_directory/meetings/urls.py 2012-12-04 21:25:51 +0000
3+++ loco_directory/meetings/urls.py 2013-04-14 23:02:24 +0000
4@@ -17,6 +17,7 @@
5 url(r'^add/$', 'meetings.views.team_meeting_select', name='team-meeting-select'),
6
7 url(r'^team/(?P<team_meeting_id>\d+)/agenda/(?P<agenda_item_id>\d+)/delete/$', 'meetings.views.agenda_item_delete', name='agenda-item-delete'),
8+ url(r'^team/(?P<team_meeting_id>\d+)/agenda/(?P<agenda_item_id>\d+)/add-child/$', 'meetings.views.agenda_item_new', name='agenda-item-add-child'),
9 url(r'^team/(?P<team_meeting_id>\d+)/agenda/(?P<agenda_item_id>\d+)/update/$', 'meetings.views.agenda_item_update', name='agenda-item-update'),
10 url(r'^team/(?P<team_meeting_id>\d+)/agenda/add/$', 'meetings.views.agenda_item_new', name='agenda-item-new'),
11
12
13=== modified file 'loco_directory/meetings/views.py'
14--- loco_directory/meetings/views.py 2013-03-31 12:32:27 +0000
15+++ loco_directory/meetings/views.py 2013-04-14 23:02:24 +0000
16@@ -275,27 +275,37 @@
17 context = {
18 'form': form,
19 }
20- return render_to_response('meetings/team_meeting_update.html',
21- context, RequestContext(request))
22+ return render_to_response(
23+ 'meetings/team_meeting_update.html',
24+ context,
25+ RequestContext(request)
26+ )
27 else:
28 request.user.message_set.create(message='%s %s' % (_('You can not update this team meeting.'), _('You are not a member of the team or on the LoCo Council.')))
29 return redirect(team_meeting_object)
30
31
32 @login_required
33-def agenda_item_new(request, team_meeting_id):
34+def agenda_item_new(request, team_meeting_id, agenda_item_id=None):
35 """
36 new agenda item
37 """
38 team_meeting_object = get_object_or_404(TeamMeeting, pk=team_meeting_id)
39 try:
40 user = UserProfile.objects.get(user=request.user)
41- agenda_item_object = AgendaItem(meeting=team_meeting_object,
42- owner=user,
43- created_date=datetime.datetime.now())
44+ agenda_item_object = AgendaItem(
45+ meeting=team_meeting_object,
46+ owner=user,
47+ created_date=datetime.datetime.now()
48+ )
49 except UserProfile.DoesNotExist:
50- agenda_item_object = AgendaItem(meeting=team_meeting_object,
51- created_date=datetime.datetime.now())
52+ agenda_item_object = AgendaItem(
53+ meeting=team_meeting_object,
54+ created_date=datetime.datetime.now()
55+ )
56+
57+ if agenda_item_id is not None:
58+ agenda_item_object.parent = get_object_or_404(AgendaItem, pk=agenda_item_id)
59 is_member = False
60 for team in team_meeting_object.teams.all():
61 if launchpad.is_team_member(request.user, team):
62
63=== modified file 'loco_directory/templates/meetings/agenda_item_update.html'
64--- loco_directory/templates/meetings/agenda_item_update.html 2013-03-31 12:32:27 +0000
65+++ loco_directory/templates/meetings/agenda_item_update.html 2013-04-14 23:02:24 +0000
66@@ -5,6 +5,7 @@
67
68 {% block sub_nav_links %}
69 <li><a class="sub-nav-item" href="{% url team-meeting-detail team_meeting_object.first_team.lp_name team_meeting_object.id %}">{% trans "Back to Meeting Details" %}</a></li>
70+<li><a class="sub-nav-item" href="{% url agenda-item-add-child team_meeting_object.id agenda_item_object.id %}">{% trans "Add Child Item" %}</a></li>
71 <li><a class="sub-nav-item" href="{% url agenda-item-delete team_meeting_object.id agenda_item_object.id %}">{% trans "Delete Agenda Item" %}</a></li>
72 {% endblock %}
73
74
75=== modified file 'loco_directory/templates/meetings/team_meeting_detail.inc.html'
76--- loco_directory/templates/meetings/team_meeting_detail.inc.html 2012-12-12 23:47:58 +0000
77+++ loco_directory/templates/meetings/team_meeting_detail.inc.html 2013-04-14 23:02:24 +0000
78@@ -4,12 +4,9 @@
79 <div class="box_content">
80 <div class="pagelet">
81 <h3>{{ team_meeting_object.name }}</h3>
82-
83 {% include "meetings/team_meeting_detail_basic.inc.html" %}
84 </div>
85-
86 {% include "meetings/team_meeting_detail_agenda.inc.html" %}
87-
88 </div>
89 </section>
90 </div>
91
92=== modified file 'loco_directory/templates/meetings/team_meeting_detail_agenda.inc.html'
93--- loco_directory/templates/meetings/team_meeting_detail_agenda.inc.html 2013-03-11 12:30:52 +0000
94+++ loco_directory/templates/meetings/team_meeting_detail_agenda.inc.html 2013-04-14 23:02:24 +0000
95@@ -1,7 +1,7 @@
96 {% load i18n markup %}
97 {% load recurse %}
98 {% if user_is_team_member %}
99- <a href="{% url agenda-item-new team_meeting_object.id %}">{% trans 'Add Agenda Item' %}</a>
100+ <a style="margin-bottom: 10px;" class="contact-button" href="{% url agenda-item-new team_meeting_object.id %}">{% trans 'Add Agenda Item' %}</a>
101 {% endif %}
102
103 {% if team_meeting_object.agenda %}

Subscribers

People subscribed via source and target branches