Merge lp:~daker/loco-team-portal/fix.635799 into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Chris Johnston
Approved revision: 472
Merged at revision: 493
Proposed branch: lp:~daker/loco-team-portal/fix.635799
Merge into: lp:loco-team-portal
Diff against target: 12 lines (+1/-1)
1 file modified
loco_directory/teams/views.py (+1/-1)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.635799
Reviewer Review Type Date Requested Status
Chris Johnston Approve
Review via email: mp+71786@code.launchpad.net

Commit message

Added alphabetical order to Re-approvals.

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

This sorts them by name and then by date, it needs to be by date and then by name.

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/teams/views.py'
2--- loco_directory/teams/views.py 2011-07-24 15:12:36 +0000
3+++ loco_directory/teams/views.py 2011-10-10 16:09:24 +0000
4@@ -28,7 +28,7 @@
5
6 def reapprovals(request):
7 teams = filter(lambda a: a.approved and a.expires_date != None,
8- Team.objects.all().order_by('expires_date'))
9+ Team.objects.all().order_by('expires_date', 'name'))
10 today = datetime.date.today()
11 half_a_year = datetime.timedelta(days=180)
12 # XXX: we have no idea why, but on loco.ubuntu.com we are dealing with

Subscribers

People subscribed via source and target branches