Merge lp:~daker/loco-team-portal/fix.1542697 into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Needs review
Proposed branch: lp:~daker/loco-team-portal/fix.1542697
Merge into: lp:loco-team-portal
Diff against target: 25 lines (+2/-2)
2 files modified
Makefile (+1/-1)
loco_directory/articles/ (+1/-1)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.1542697
Reviewer Review Type Date Requested Status
Lucy Llewellyn (community) Needs Fixing
Chris Johnston Approve
Review via email:

Commit message

Fixed feed date parsing

Description of the change

Fixed feed date parsing

To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve
Revision history for this message
Lucy Llewellyn (lucyllewy) wrote :

The modified parameter is not to be set by us. We are supposed to use whatever the server we're fetching-from has previously told us the feed was last modified. We should also have etag functionality included in this MR. See for details.

Saving the correct last-modified time should be:

self.last_updated = data.modified_parsed

and an etag would be accessed, and saved into a new field, from the response with:

self.last_etag = data.etag

we'd need to add the last_etag field into the model and update the migrations.

review: Needs Fixing

Unmerged revisions

685. By Adnane Belmadiaf

Fixed feed date parsing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2016-02-12 00:54:37 +0000
3+++ Makefile 2016-03-20 15:47:31 +0000
4@@ -39,7 +39,7 @@
5 $(django_manage) runserver
7 test: env apps
8- $(django_manage) test teams events venues meetings userprofiles
9+ $(django_manage) test teams events venues meetings userprofiles articles
11 clean:
12 rm -rf env/
14=== modified file 'loco_directory/articles/'
15--- loco_directory/articles/ 2012-12-25 22:00:46 +0000
16+++ loco_directory/articles/ 2016-03-20 15:47:31 +0000
17@@ -68,7 +68,7 @@
19 if self.title is None or self.title == '':
20 self.title = data.feed.title
21- self.last_updated = datetime.datetime.fromtimestamp(time.mktime(getattr(data, 'modified', time.gmtime())))
22+ self.last_updated = datetime.datetime.fromtimestamp(time.mktime(time.gmtime()))
25 for entry in data.entries:


People subscribed via source and target branches