Merge lp:~daker/loco-team-portal/fix.681984 into lp:loco-team-portal

Proposed by Adnane Belmadiaf
Status: Merged
Approved by: Chris Johnston
Approved revision: 351
Merged at revision: 354
Proposed branch: lp:~daker/loco-team-portal/fix.681984
Merge into: lp:loco-team-portal
Diff against target: 66 lines (+9/-7)
3 files modified
loco_directory/events/views.py (+3/-2)
loco_directory/meetings/views.py (+3/-2)
loco_directory/venues/views.py (+3/-3)
To merge this branch: bzr merge lp:~daker/loco-team-portal/fix.681984
Reviewer Review Type Date Requested Status
Chris Johnston Needs Fixing
Review via email: mp+45088@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Johnston (cjohnston) wrote :

Could you please expand this to work with meetings also?

349. By Adnane Belmadiaf

* Redirect the user to meeting details after we create it

350. By Adnane Belmadiaf

* Fixed the url name

Revision history for this message
Chris Johnston (cjohnston) wrote :

raceback:
File "/usr/lib/pymodules/python2.6/django/core/handlers/base.py" in get_response
  100. response = callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/pymodules/python2.6/django/contrib/auth/decorators.py" in _wrapped_view
  25. return view_func(request, *args, **kwargs)
File "/home/chris/Dropbox/Projects/loco-directory/loco-directory/loco_directory/meetings/views.py" in team_meeting_new
  181. return HttpResponseRedirect(reverse('team-meeting-detail', kwargs={'team_meeting_id': team_meeting_id}))

Exception Type: NameError at /meetings/team/ubuntu-us-florida/add/
Exception Value: global name 'reverse' is not defined

review: Needs Fixing
351. By Adnane Belmadiaf

* Forgot to import reverse

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'loco_directory/events/views.py'
2--- loco_directory/events/views.py 2010-12-30 19:46:26 +0000
3+++ loco_directory/events/views.py 2011-01-05 15:59:18 +0000
4@@ -4,6 +4,7 @@
5 from django.shortcuts import get_object_or_404
6 from django.contrib.auth.decorators import login_required
7 from django.utils.translation import ugettext as _
8+from django.core.urlresolvers import reverse
9
10 from events.models import TeamEvent
11 from events.models import GlobalEvent
12@@ -201,8 +202,8 @@
13 if form.is_valid():
14 team_event = form.save()
15 team_event.teams.add(team_object)
16- request.user.message_set.create(message=_('New event created.'))
17- return redirect( team_object )
18+ team_event_id = team_event.id
19+ return HttpResponseRedirect(reverse('team-event-detail', kwargs={'team_event_id': team_event_id}))
20 else:
21 form = TeamEventForm(initial={'global_event':request.GET.get('global_event_id', None)}, teams=[team_object])
22 if request.GET.has_key('global_event_id'):
23
24=== modified file 'loco_directory/meetings/views.py'
25--- loco_directory/meetings/views.py 2010-12-19 20:26:12 +0000
26+++ loco_directory/meetings/views.py 2011-01-05 15:59:18 +0000
27@@ -4,6 +4,7 @@
28 from django.shortcuts import get_object_or_404
29 from django.contrib.auth.decorators import login_required
30 from django.utils.translation import ugettext as _
31+from django.core.urlresolvers import reverse
32
33 from meetings.models import TeamMeeting
34 from teams.models import Team
35@@ -177,8 +178,8 @@
36 if form.is_valid():
37 team_meeting = form.save()
38 team_meeting.teams.add(team_object)
39- request.user.message_set.create(message=_('New meeting created.'))
40- return redirect( team_object )
41+ team_meeting_id = team_meeting.id
42+ return HttpResponseRedirect(reverse('team-meeting-detail', kwargs={'team_meeting_id': team_meeting_id}))
43 else:
44 form = TeamMeetingForm(team=team_object)
45
46
47=== modified file 'loco_directory/venues/views.py'
48--- loco_directory/venues/views.py 2010-11-20 17:40:31 +0000
49+++ loco_directory/venues/views.py 2011-01-05 15:59:18 +0000
50@@ -52,14 +52,14 @@
51 if request.method == 'POST':
52 form = VenueForm(data=request.POST, instance=venue_object)
53 if form.is_valid():
54- form.save()
55- request.user.message_set.create(message=_('New Venue created'))
56+ new_venue = form.save()
57+ new_venue_id = new_venue.id
58 if request.REQUEST.has_key('_popup'):
59 return HttpResponse('<script type="text/javascript">opener.dismissAddAnotherPopup(window, "%s", "%s");</script>' % \
60 # escape() calls force_unicode.
61 (escape(venue_object.pk), escape(venue_object)))
62 else:
63- return HttpResponseRedirect( reverse( 'venue-list' ) )
64+ return HttpResponseRedirect(reverse('venue-detail', kwargs={'venue_id': new_venue_id}))
65 else:
66 form = VenueForm()
67

Subscribers

People subscribed via source and target branches