MAAS

~d0ugal/maas:bug/1876855

Git
lp:~d0ugal/maas
bug/1876855

Last commit made on 2020-06-15

Get this branch:: git clone -b bug/1876855 https://git.launchpad.net/~d0ugal/maas

Only Dougal Matthews can upload to this branch. If you are Dougal Matthews please log in for upload directions.

Branch merges

Merged into maas:master

MAAS Lander: Approve on 2020-06-12

Lee Trager (community): Approve on 2020-06-11

Branch information

Name:: bug/1876855

Repository:: lp:~d0ugal/maas

Recent commits

e1568b0... by Dougal Matthews on 2020-05-21

Identify power drivers that can be used with add_chassis

This is a WIP change. Posting it for discussion.

- It adds a new property to the power drivers to identify those that can
  be used with add chassis.
- To handle backwards compatability there is also a new alias field so
  we can handle the different names used for power drivers such as virsh
  vs powerkvm and sm15k vs seamicro15k

Todo:
- Move the method in registry.py
- Allow filtering via the websocket api, so that the
generap.power_drivers method can return only those that can be used with
add_chassis.

Use can_probe rather than add_chassis

Lint

Add can_probe to the docstring and pass it along

Updated PowerDriverBase schema and corrected chassis spelling

Add can_probe to the pod drivers and the abstract base class

Use the existing get_all_power_types method

Fix the use of get_all_power_types

Make sure we allow both the names and the aliases

Correctly pass the aliases via rpc

Fix the driver parameters tests

Blacken

Don't add aliases for power drivers.

I think this overcomplicated things too much and essentially created a
new "feature" to work around the fact that the rest API allowed some
names previously that were different. Instead I think a more correct fix
is to add a small workaround in the API itself. Possibly with a warning
or log message noting that a deprecated name was used.

Add can_probe to the fake power driver

Fix tests

Filter by can_probe

Disable can_probe in lxd and rsd and add a test

Update submodule

bc4088f... by Adam Collard <email address hidden> on 2020-06-12

Update maas-ui to fecc2f45ed15ac3717cdb930dcac5c91cb46c780

2716e9b... by Dougal Matthews on 2020-06-12

Remove the virsh and lxd power drivers and error on registry overwrites

Previously if a key was reused in the registry then the existing item
would be silently replaced with the new one. Now unregister_item needs
to be used before replacing a key.

The old behaviour led to the virsh and lxd power drivers being
registered but unused (as they were replaced by pod drivers with the
same name). They have been removed.

04d6ae2... by Caleb Ellis on 2020-06-12