Merge lp:~d06alexandrov/ubuntu/precise/netams/fix-for-mysql-load-data into lp:ubuntu/precise/netams

Proposed by Dmitriy Alexandrov
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~d06alexandrov/ubuntu/precise/netams/fix-for-mysql-load-data
Merge into: lp:ubuntu/precise/netams
Diff against target: 46 lines (+26/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/16_fix_mysql_load_data.patch (+18/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~d06alexandrov/ubuntu/precise/netams/fix-for-mysql-load-data
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+118266@code.launchpad.net

Description of the change

Netams doesn't work correctly with current version of MySQL (5.5). When program uses "LOAD DATA CONCURRENT LOCAL INFILE ..." statement, MySQL's "Malformed package" error occurs.
The reason is that in old version (such as 5.0) of mysqlclient "local infile" option is set to "true" by default and all works correctly, but in the latest version it is set to "false". But according to MySQL manual (http://dev.mysql.com/doc/refman/5.5/en/load-data-local.html), using of "LOAD DATA LOCAL" statement requires call of mysql_options(..., MYSQL_OPT_LOCAL_INFILE, 0).

To post a comment you must log in.
Revision history for this message
Stéphane Graber (stgraber) wrote :

Was that change sent to Debian and/or upstream?

Revision history for this message
Dmitriy Alexandrov (d06alexandrov) wrote :

> Was that change sent to Debian and/or upstream?

I have got package source by using "bzr branch ubuntu:netams" and then commited patch by using "bzr push lp:~d06alexandrov/ubuntu/precise/netams/fix-for-mysql-load-data". I am a newby, but is that means, that change was not sent to Debian and upstream? And what should i do?

Revision history for this message
Iain Lane (laney) wrote :

There's a guide at <http://developer.ubuntu.com/packaging/html/fixing-a-bug-example.html#getting-the-fix-included> which tells you how to do this, using the submittodebian command. Please could you do this? I'm still going to look at your branch however.

Revision history for this message
Iain Lane (laney) wrote :

Hm, this package is removed from Quantal.

This is a stable release update. The bar for such uploads is quite high; do you think this upload is very important to be fixed in Precise? If so, you'll need to follow the procedure at https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

Subscribe me to the bug when you've filed it and I'll take a look.

Revision history for this message
Dmitriy Alexandrov (d06alexandrov) wrote :

I've tried to use the submittodebian, and it has been registered to bugtracker (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=689435). But netams has been removed from debian a month ago.

And subscribed to https://bugs.launchpad.net/ubuntu/+source/netams/+bug/1060320

Revision history for this message
Michael Terry (mterry) wrote :

Sounds like discussion/tracking has moved to the bug. I'll mark this as Work In Progress to keep it from showing up in sponsor reports.

Revision history for this message
Michael Terry (mterry) wrote :

Whoops, nevermind. I can't change it. :)

Revision history for this message
Martin Pitt (pitti) wrote :

I'll use the debdiff from bug 1060320 for sponsoring, as that's easier for SRUs. Thanks!

I close this MP.

Unmerged revisions

8. By Dmitriy Alexandrov

debian/patches/16_fix_mysql_load_data.patch: fix errors with usage
of mysql's statement "LOAD DATA LOCAL INFILE".

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-11-23 23:58:46 +0000
3+++ debian/changelog 2012-08-05 14:11:21 +0000
4@@ -1,3 +1,10 @@
5+netams (3.4.5-2ubuntu3) precise; urgency=low
6+
7+ * debian/patches/16_fix_mysql_load_data.patch: fix errors with usage
8+ of mysql's statement "LOAD DATA LOCAL INFILE".
9+
10+ -- Dmitriy Alexandrov <d06alexandrov@gmail.com> Sun, 05 Aug 2012 15:45:07 +0400
11+
12 netams (3.4.5-2ubuntu2) precise; urgency=low
13
14 * Rebuild for libmysqlclient transition
15
16=== added file 'debian/patches/16_fix_mysql_load_data.patch'
17--- debian/patches/16_fix_mysql_load_data.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/16_fix_mysql_load_data.patch 2012-08-05 14:11:21 +0000
19@@ -0,0 +1,18 @@
20+Description: Set 'local-infile' option for using with MySQL.
21+ According to MySQL's manual, using of "LOAD DATA LOCAL INFILE"
22+ statement requires 'local-infile' option set to 'true'. Without that,
23+ 'Malformed packet' error occurs.
24+Author: Dmitriy Alexandrov <d06alexandrov@gmail.com>
25+Index: netams.dev/src/st_sql_mysql.c
26+===================================================================
27+--- netams.dev.orig/src/st_sql_mysql.c 2012-08-05 15:38:01.000000000 +0400
28++++ netams.dev/src/st_sql_mysql.c 2012-08-05 15:45:01.000000000 +0400
29+@@ -56,6 +56,8 @@
30+ return NULL;
31+ }
32+
33++ mysql_options(fd, MYSQL_OPT_LOCAL_INFILE, 0);
34++
35+ my_host=cfg->hostname;
36+ my_user=cfg->username;
37+ my_pass=cfg->password;
38
39=== modified file 'debian/patches/series'
40--- debian/patches/series 2010-07-06 03:29:43 +0000
41+++ debian/patches/series 2012-08-05 14:11:21 +0000
42@@ -7,3 +7,4 @@
43 13_netams_web_conf.diff
44 14_fix_pthread.diff
45 15_fix_ftbfs_kfreebsd.diff
46+16_fix_mysql_load_data.patch

Subscribers

People subscribed via source and target branches