Merge lp:~d.filoni/telegram-app/bug1600706 into lp:telegram-app

Proposed by Devid Antonio Filoni on 2016-10-15
Status: Merged
Approved by: Jin on 2016-11-01
Approved revision: 240
Merged at revision: 243
Proposed branch: lp:~d.filoni/telegram-app/bug1600706
Merge into: lp:telegram-app
Diff against target: 15 lines (+1/-4)
1 file modified
telegram/app/qml/AccountListItem.qml (+1/-4)
To merge this branch: bzr merge lp:~d.filoni/telegram-app/bug1600706
Reviewer Review Type Date Requested Status
Jin (community) 2016-10-15 Approve on 2016-11-01
Review via email: mp+308579@code.launchpad.net

Description of the change

This MR partially reverts commit 209 in order to fix bug #1600706.
PHONE_NUMBER_INVALID error is returned also when an invalid/not-yet-on-telegram phone number is added as contact and we should not remove current active number from profiles when it does.
Tested on mako, commit 209 change was introduced in order to "fix hanging if user enters already existing number", I tried also to login-as/add-as-contact an already existing number and the app didn't hang or crash so I think everything works as expected.

To post a comment you must log in.
Jin (jindallo) wrote :

Hello Devid,

Code looks good,
and verified pass on my local.

I approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'telegram/app/qml/AccountListItem.qml'
2--- telegram/app/qml/AccountListItem.qml 2016-07-04 07:27:52 +0000
3+++ telegram/app/qml/AccountListItem.qml 2016-10-15 22:56:51 +0000
4@@ -86,10 +86,7 @@
5 mainView.error(id, errorCode, errorText)
6 }
7 onErrorChanged: {
8- console.log("auth error: " + error)
9- if (error == "PHONE_NUMBER_INVALID") {
10- profiles.remove(telegram.phoneNumber);
11- }
12+ console.log("telegram error: " + error)
13 }
14 onAuthNeededChanged: {
15 console.log("authNeeded " + authNeeded)

Subscribers

People subscribed via source and target branches

to status/vote changes: