lp:~d.filoni/indicator-sound/pulse_fix_set_volume_role

Created by Devid Antonio Filoni on 2016-08-10 and last modified on 2016-08-10
Get this branch:
bzr branch lp:~d.filoni/indicator-sound/pulse_fix_set_volume_role
Only Devid Antonio Filoni can upload to this branch. If you are Devid Antonio Filoni please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Devid Antonio Filoni
Project:
The Sound Menu
Status:
Mature

Recent revisions

540. By Devid Antonio Filoni on 2016-08-10

volume-control-pulse: handle a concurrency issue in role volume set. In particular circumstances indicator-sound changes the volume of a role using the previous set role one, this happens when it intercepts an external volume change signal (from example from AccountsService) while reading new role from pulse (which requires two DBus calls). Both Vala methods (set_volume_active_role and update_active_sink_input) are async.

539. By CI Train Bot Account on 2016-04-18

Releasing 12.10.2+16.04.20160418.1-0ubuntu1

538. By Xavi Garcia on 2016-04-18

This branch adds a new signal in volumeWarning to set the warning level volume after pressing cancel.
We are setting the warning level before pressing cancel, which is alright, but sometimes we have issues with the value set to the accounts service that steps on the warning level. Fixes: #1570779
Approved by: PS Jenkins bot, Charles Kerr

537. By CI Train Bot Account on 2016-04-06

Releasing 12.10.2+16.04.20160406-0ubuntu1

536. By Dmitry Shachnev on 2016-04-06

Support multiple desktop names in $XDG_CURRENT_DESKTOP. Fixes: #1502480
Approved by: Alkis Georgopoulos, Mystic-Mirage, Charles Kerr, Alberts Muktupāvels

535. By CI Train Bot Account on 2016-03-17

Releasing 12.10.2+16.04.20160317.1-0ubuntu1

534. By Xavi Garcia on 2016-03-17

Changed to code to get the root icon. Now it does not take into account the source output, as in fact that code was not differentiating between any particular case.
The code was added in the past in the case that we should differentiate between bluetooth, headphones, etc... but it was never used. Fixes: #1555831
Approved by: Charles Kerr

533. By CI Train Bot Account on 2016-03-07

Releasing 12.10.2+16.04.20160307-0ubuntu1

532. By Xavi Garcia on 2016-03-07

Add changes to show up the microphone controls when an external microphone is detected.
Approved by: PS Jenkins bot, Charles Kerr

531. By Xavi Garcia on 2016-03-07

To avoid going too below the warning level we set the volume when showing the warning dialog to the loud_volume level.

The spec states:
Whenever you increase volume, for the first time in 20 hours, such that acoustic output would be more than 85 dBA, an “Increase Volume” dialog should appear.

So the loud_volume is still a valid level.

After setting this the user has only to press the Up button once to show the warning dialog again.
When setting the loud_volume-1 value the level was decreased 2 steps below the warning level and the used had to press the up button twice.
Approved by: PS Jenkins bot, Charles Kerr

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:indicator-sound
This branch contains Public information 
Everyone can see this information.