Code review comment for lp:~d.filoni/account-polld/lp1481202

I thought there was an existing way for the app to supply the sound file as
part of the click package and specify that in the manifest? Adding Arthur
here as I believe Telegram app is already doing this..

On Tue, Nov 22, 2016 at 7:49 AM, Jonas G. Drange <<email address hidden>
> wrote:

> Review: Needs Information
>
> Sorry for the lag, Devid. Thanks for the branch.
>
> I think the execution is great, but I worry about duplicating code that
> already exist in ubuntu-push. If you look in ubuntu-push/bus/notifications/raw.go,
> this Presenter is the one dispatching the Unity Notification to Unity8
> (which is ultimately responsible for producing a bubble and a sound).
>
> Further, ubuntu-push is already informed about settings in
> AccountsService. Maybe ubuntu-push should make the decision what sound to
> play?
>
> So I think the real issue is that account-polld is providing a sound file
> at all.
>
> What do you think?
> --
> https://code.launchpad.net/~d.filoni/account-polld/lp1481202/+merge/304710
> Your team Ubuntu Push Hackers is subscribed to branch
> lp:~ubuntu-push-hackers/account-polld/trunk.
>