Merge lp:~d-danielbeck/dekko/NewSplashScreen into lp:dekko/0.3
Proposed by
Daniel Beck
| Status: | Rejected |
|---|---|
| Rejected by: | Dan Chapman |
| Proposed branch: | lp:~d-danielbeck/dekko/NewSplashScreen |
| Merge into: | lp:dekko/0.3 |
| Diff against target: |
9 lines (+2/-0) 1 file modified
src/app/dekko.desktop (+2/-0) |
| To merge this branch: | bzr merge lp:~d-danielbeck/dekko/NewSplashScreen |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dan Chapman | Needs Information | ||
|
Review via email:
|
|||
Description of the change
Dekko should use the new splash screen features. Bug 1377638.
To post a comment you must log in.
Revision history for this message
| Dan Chapman (dpniel) wrote | # |
Revision history for this message
| Dan Chapman (dpniel) | # |
review:
Needs Information
Unmerged revisions
- 99. By Daniel Beck
-
Dekko should use the new splash screen features. Bug 1377638.
- 98. By Daniel Beck
-
merged trunk.
- 97. By Daniel Beck
-
merged from trunk
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hey thanks for this.
I have a couple of concerns with displaying a title here. We are not always *guaranteed* to land in "Mailbox" if either there is no account configured or more than one account is configured
These would both cause the title to be "Accounts".
Also when we get to the point of a setup wizard (At the moment we just hack our way through the settings tabs confirming everything we need is given before proceeding) it will be another different title/landing page.
What about just a coloured background? Not sure what colour though, so that we don't show conflicting titles between the splash and landing page. Or use "Dekko" as the title but that might look weird tbh.
What's your thoughts?