Merge ~cypressyew/qa-regression-testing:phlin/text-mode-for-config-gz into qa-regression-testing:master

[Po-Hsu Lin]

While testing J-xilinx kernel, all of the KernelSecurityConfigTests
are failing with:

Traceback (most recent call last):
  File "./test-kernel-security.py", line 2215, in test_010_kaslr_config
    self.assertKernelConfig('RANDOMIZE_BASE', expected)
  File "./test-kernel-security.py", line 231, in assertKernelConfig
    self.assertKernelConfigSet(name)
  File "./test-kernel-security.py", line 217, in assertKernelConfigSet
    self.assertTrue(self._test_config(name),
  File "./test-kernel-security.py", line 199, in _test_config
    setting = self._get_config(name)
  File "./test-kernel-security.py", line 193, in _get_config
    if line.startswith('CONFIG_%s=' % (name)):
TypeError: startswith first arg must be bytes or a tuple of bytes, not str

This is because the /proc/config.gz was not opened in text mode with
the python gzip module. Set it to 'rt' (text mode) to fix this issue.

[Po-Hsu Lin (cypressyew)]

Please find the config.gz copied from the J-xilinx unit here:
https://people.canonical.com/~phlin/qrt/config.gz

Read it with:
import gzip
with gzip.open('config.gz', 'r') as f:
  content = f.readlines()

And check the content.

[Steve Beattie (sbeattie)]

Ack, sorry for the delay, merged.

review: Approve

diff --git a/scripts/test-kernel-security.py b/scripts/test-kernel-security.py
index ba1a5b3..61d662f 100755
--- a/scripts/test-kernel-security.py
+++ b/scripts/test-kernel-security.py
@@ -172,7 +172,7 @@ class KernelSecurityBaseTest(testlib.TestlibCase):
     def _open_config(self):
         name = "/proc/config.gz"
         if os.path.exists(name):
-            return gzip.open(name, "r")
+            return gzip.open(name, "rt")
         for name in ["/boot/config-%s" % (self.kernel_version),
                      "/boot/config"]:
             if os.path.exists(name):