QA Regression Testing

Merge ~cypressyew/qa-regression-testing:fix-test-kernel-panic into qa-regression-testing:master

  1. Git
  2. lp:~cypressyew/qa-regression-testing
  3. fix-test-kernel-panic
  4. Merge into master
Proposed by Po-Hsu Lin
Status: Merged
Merged at revision: 9c13d4625b41fa9e8e3fd0924e968ebbe0f2dca6
Proposed branch: ~cypressyew/qa-regression-testing:fix-test-kernel-panic
Merge into: qa-regression-testing:master
Diff against target: 11 lines (+0/-1)
1 file modified
scripts/test-kernel-panic.py (+0/-1)
Reviewer Review Type Date Requested Status
Steve Beattie Approve
Review via email: mp+382153@code.launchpad.net

Commit message

There is a comment that should be removed when re-enabling test_cve_2016_10208.

Fixes: e3a50374636c ("test-kernel-panic: re-enable CVE-2016-10208 test")

To post a comment you must log in.
Revision history for this message
Steve Beattie (sbeattie) wrote :

Bah, thanks for catching that. Merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/test-kernel-panic.py b/scripts/test-kernel-panic.py
2index 09b5939..c1e7009 100755
3--- a/scripts/test-kernel-panic.py
4+++ b/scripts/test-kernel-panic.py
5@@ -126,7 +126,6 @@ class KernelPanicTest(testlib.TestlibCase, PrivateKernelPanicTest):
6 self.assertShellExitEquals(1, ['keyctl', 'request2', 'trusted', 'user', '', '@u'])
7 output = self.assertShellExitEquals(expected, ['keyctl', 'add', 'trusted', 'user', 'a', '@u'], bare_report=True)
8
9-Disabling: test has only been fixed on xenial so far
10 def test_cve_2016_10208(self):
11 '''test kernel with invalid s_first_meta_bg (CVE-2016-10208)'''
12

Subscribers

People subscribed via source and target branches