QA Regression Testing

Merge ~cypressyew/qa-regression-testing:smep-make-clean into qa-regression-testing:master

  1. Git
  2. lp:~cypressyew/qa-regression-testing
  3. smep-make-clean
  4. Merge into master
Proposed by Po-Hsu Lin
Status: Merged
Merge reported by: Steve Beattie
Merged at revision: 1aae5253815f1920a91bfd32c4797cc416bd7af7
Proposed branch: ~cypressyew/qa-regression-testing:smep-make-clean
Merge into: qa-regression-testing:master
Diff against target: 12 lines (+1/-0)
1 file modified
scripts/test-kernel-security.py (+1/-0)
Reviewer Review Type Date Requested Status
Steve Beattie Approve
Review via email: mp+355493@code.launchpad.net

Commit message

The execuser.ko module won't get rebuild when switching to a different kernel on the same system and it will cause false-negative results.

Run make clean at the very beginning of this test to make sure the module is fresh to each kernel.

To post a comment you must log in.
Revision history for this message
Steve Beattie (sbeattie) wrote :

LGTM, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/scripts/test-kernel-security.py b/scripts/test-kernel-security.py
2index 3f98e2e..db8fe4c 100755
3--- a/scripts/test-kernel-security.py
4+++ b/scripts/test-kernel-security.py
5@@ -1489,6 +1489,7 @@ class KernelSecurityTest(KernelSecurityBaseTest):
6
7 os.chdir('smep')
8 if self.kernel_is_ubuntu:
9+ self.assertShellExitEquals(0, ["make", "clean"])
10 self.assertShellExitEquals(0, ["make"])
11
12 # Find a value to test in memory.

Subscribers

People subscribed via source and target branches