Merge lp:~cypressyew/checkbox/input_click_jobs into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2953
Merged at revision: 2956
Proposed branch: lp:~cypressyew/checkbox/input_click_jobs
Merge into: lp:checkbox
Diff against target: 56 lines (+27/-0)
3 files modified
providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist (+2/-0)
providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist (+2/-0)
providers/plainbox-provider-checkbox/jobs/input.txt.in (+23/-0)
To merge this branch: bzr merge lp:~cypressyew/checkbox/input_click_jobs
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Po-Hsu Lin Needs Resubmitting
Ara Pulido (community) Needs Fixing
Review via email: mp+217386@code.launchpad.net

Description of the change

A manual local job for testing click events on input devices

We could improve it with event capture later.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Add a summary line to all jobs (local and generated jobs)

review: Needs Fixing
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Add a summary line to all jobs (local and generated jobs)

review: Needs Fixing
Revision history for this message
Ara Pulido (ara) wrote :

We need to add the new jobs to the client-cert whitelist as well.

review: Needs Fixing
2953. By Po-Hsu Lin

Summary added, alse added into client-cert whitelist

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Whitelist and summary added, thanks!

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Looks good now, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
2--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2014-04-26 10:55:31 +0000
3+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2014-04-28 08:23:04 +0000
4@@ -108,6 +108,8 @@
5 input/accelerometer
6 input/pointing
7 input/pointing_.*
8+input/clicking
9+input/clicking_.*
10 input/keyboard
11 disk/hdd-parking
12 __keys__
13
14=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
15--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2014-04-26 10:55:31 +0000
16+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2014-04-28 08:23:04 +0000
17@@ -105,6 +105,8 @@
18 input/accelerometer
19 input/pointing
20 input/pointing_.*
21+input/clicking
22+input/clicking_.*
23 input/keyboard
24 disk/hdd-parking
25 __keys__
26
27=== modified file 'providers/plainbox-provider-checkbox/jobs/input.txt.in'
28--- providers/plainbox-provider-checkbox/jobs/input.txt.in 2014-04-07 16:33:10 +0000
29+++ providers/plainbox-provider-checkbox/jobs/input.txt.in 2014-04-28 08:23:04 +0000
30@@ -65,3 +65,26 @@
31 2. Tilt your hardware in the directions onscreen until the axis threshold is met.
32 VERIFICATION:
33 Is your accelerometer properly detected? Can you use the device?
34+
35+plugin: local
36+id: input/clicking
37+requires:
38+ device.category == 'MOUSE' or device.category == 'TOUCHPAD'
39+_summary: Create click tests for pointing devices.
40+_description: Click tests for pointing devices.
41+command:
42+ cat <<'EOF' | run_templates -t -s 'udev_resource | filter_templates -w "category=MOUSE" -w "category=TOUCHPAD"'
43+ plugin: manual
44+ id: input/clicking_`echo "${product}_${category}" | sed 's/ /_/g;s/[^_a-zA-Z0-9-]//g'`_`basename $path`
45+ requires: device.path == "$path"
46+ _summary: Check button functionality for $product
47+ _description:
48+ PURPOSE:
49+ This will test the buttons of your $product device
50+ STEPS:
51+ 1. Click the left button with your $product.
52+ 2. Click the right button with your $product.
53+ 3. Click the middle button with your $product (if available).
54+ VERIFICATION:
55+ Did these buttons work as expected?
56+ EOF

Subscribers

People subscribed via source and target branches