Merge lp:~cypressyew/checkbox/fix-tb-generator into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3796
Merged at revision: 3799
Proposed branch: lp:~cypressyew/checkbox/fix-tb-generator
Merge into: lp:checkbox
Diff against target: 22 lines (+2/-2)
1 file modified
providers/plainbox-provider-checkbox/jobs/audio.txt.in (+2/-2)
To merge this branch: bzr merge lp:~cypressyew/checkbox/fix-tb-generator
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+259586@code.launchpad.net

Description of the change

Change the manifest requirement from the generator to the generated job, to avoid unwanted generator skipping issue.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/jobs/audio.txt.in'
2--- providers/plainbox-provider-checkbox/jobs/audio.txt.in 2015-04-20 08:37:57 +0000
3+++ providers/plainbox-provider-checkbox/jobs/audio.txt.in 2015-05-20 09:25:44 +0000
4@@ -99,9 +99,7 @@
5 EOF
6
7 id: audio/generator_playback_thunderbolt
8-imports: from 2013.com.canonical.plainbox import manifest
9 requires:
10- manifest.has_thunderbolt == 'True'
11 device.category == 'AUDIO'
12 package.name == 'alsa-base'
13 package.name == 'gir1.2-gst-plugins-base-0.10' or package.name == 'gir1.2-gst-plugins-base-1.0'
14@@ -112,6 +110,8 @@
15 command:
16 cat <<'EOF' | run_templates -t -s 'graphics_card_resource'
17 id: audio/`echo ${index}`_playback_thunderbolt_`echo "${product}" | sed 's/ /_/g;s/[^_a-zA-Z0-9-]//g'`
18+ imports: from 2013.com.canonical.plainbox import manifest
19+ requires: manifest.has_thunderbolt == 'True'
20 plugin: user-interact-verify
21 estimated_duration: 30.0
22 command:

Subscribers

People subscribed via source and target branches