Merge lp:~cypressyew/checkbox/fix-pwr-log-attach into lp:checkbox

[Po-Hsu Lin]

I tried to find the .tgz file, to see where it is after the poweroff/reboot-log-attach job. But I couldn't find them :(

So this fix is simple, just explicitly assign where the .tgz file would go.

Maybe we could do something else other than cat the .tgz file, I'm not sure why we did this.

Output from the io-logs
$ cat 2013.com.canonical.certification__power-management_poweroff-log-attach.stderr
tar: Removing leading `/' from member names
$ cat 2013.com.canonical.certification__power-management_poweroff-log-attach.stdout
/home/ubuntu/.cache/plainbox/sessions/pbox-6gbn_37h.session/CHECKBOX_DATA/pm_test.poweroff.1.log
(garbled message, you don't want to see)

[Zygmunt Krynicki (zyga)]

+1

Makes sense. The cwd of each job is wherever the use runs the app from. I think we should start to synthesize a temporary directory for each job invocation and be very vocal about any files left over (or perhaps created, as nothing should be created in the current directory.

review: Approve

[Zygmunt Krynicki (zyga)]

FYI, related improvement: https://code.launchpad.net/~zkrynicki/checkbox/exec-ctrl-sandbox/+merge/223903

=== modified file 'providers/plainbox-provider-checkbox/jobs/power-management.txt.in'
--- providers/plainbox-provider-checkbox/jobs/power-management.txt.in	2014-06-17 15:31:12 +0000
+++ providers/plainbox-provider-checkbox/jobs/power-management.txt.in	2014-06-20 10:29:37 +0000
@@ -53,7 +53,7 @@
 
 plugin: attachment
 id: power-management/poweroff-log-attach
-command: tar cvfz power-management_poweroff.tgz $PLAINBOX_SESSION_SHARE/*poweroff.1.log && cat $PLAINBOX_SESSION_SHARE/power-management_poweroff.tgz
+command: tar cvfz ${PLAINBOX_SESSION_SHARE}/power-management_poweroff.tgz ${PLAINBOX_SESSION_SHARE}/*poweroff.1.log && cat ${PLAINBOX_SESSION_SHARE}/power-management_poweroff.tgz
 _description:
  This will attach any logs from the power-management/poweroff test to the results.
 
@@ -78,7 +78,7 @@
 
 plugin: attachment
 id: power-management/reboot-log-attach
-command: tar cvfz power-management_reboot.tgz $PLAINBOX_SESSION_SHARE/*reboot.1.log && cat $PLAINBOX_SESSION_SHARE/power-management_reboot.tgz
+command: tar cvfz ${PLAINBOX_SESSION_SHARE}/power-management_reboot.tgz ${PLAINBOX_SESSION_SHARE}/*reboot.1.log && cat ${PLAINBOX_SESSION_SHARE}/power-management_reboot.tgz
 _description:
  This will attach any logs from the power-management/reboot test to the results.