Merge lp:~cypressyew/checkbox/fix-graphics-driver into lp:checkbox
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | 4127 |
Merged at revision: | 4130 |
Proposed branch: | lp:~cypressyew/checkbox/fix-graphics-driver |
Merge into: | lp:checkbox |
Diff against target: |
18 lines (+2/-2) 1 file modified
providers/plainbox-provider-checkbox/bin/graphics_driver (+2/-2) |
To merge this branch: | bzr merge lp:~cypressyew/checkbox/fix-graphics-driver |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau | Approve | ||
Paul Larson | Approve | ||
Review via email: mp+280099@code.launchpad.net |
Description of the change
Fix the driver detection issue when running with power-saving mode on I+A systems.
As the system will call Intel driver from fglrx, so instead of returning the driver name detected in the pattern for Intel GPU (which will be fglrx in this case, causing false results), we should force it to return "intel" to avoid this issue.
Tested on:
201409-15485 - Intel UMA (14.04.3)
201409-15477 - I+N in both power-saving and performance mode (14.04.3)
201507-18599 - I+A in both power-saving and performance mode (14.04 oem)
It looks like this won't affect 3.2 Precise, as the Intel pattern in Xorg.log is different before 3.11 kernel (and it does not support graphic switching with older driver on Precise)
it might make sense to check if m.group(1) == 'fglrx' just in case, but if you are certain it just needs to be this no matter what, then it may be ok. Otherwise +1