Merge lp:~cypressyew/checkbox/display-rename into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3781
Merged at revision: 3782
Proposed branch: lp:~cypressyew/checkbox/display-rename
Merge into: lp:checkbox
Diff against target: 158 lines (+16/-16)
8 files modified
providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu (+2/-2)
providers/plainbox-provider-certification-client/whitelists/client-cert-12-04-4.whitelist (+1/-1)
providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist (+2/-2)
providers/plainbox-provider-certification-client/whitelists/client-selftest-12-04-4.whitelist (+1/-1)
providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist (+2/-2)
providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist (+2/-2)
providers/plainbox-provider-checkbox/jobs/graphics.txt.in (+5/-5)
providers/plainbox-provider-checkbox/whitelists/default.whitelist (+1/-1)
To merge this branch: bzr merge lp:~cypressyew/checkbox/display-rename
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+259351@code.launchpad.net

Description of the change

Change the job name of graphic/display to graphic/video, to avoid future job name collision with suspend/display_after_suspend

I use the following command to check in which whitelist this test has been used:
find ./ -name "*" | xargs grep "graphics/.*display"

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu'
2--- providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu 2015-05-14 06:40:17 +0000
3+++ providers/plainbox-provider-certification-client/units/client-cert-14-04.pxu 2015-05-18 06:30:53 +0000
4@@ -102,7 +102,7 @@
5 graphics/1_driver_version_.* certification-status=blocker
6 graphics/1_compiz_check_.* certification-status=blocker
7 graphics/1_rotation_.* certification-status=blocker
8- graphics/1_display_.* certification-status=blocker
9+ graphics/1_video_.* certification-status=blocker
10 graphics/1_minimum_resolution_.*
11 graphics/1_cycle_resolution_.*
12 graphics/2_switch_card_.* certification-status=blocker
13@@ -111,7 +111,7 @@
14 graphics/2_driver_version_.* certification-status=blocker
15 graphics/2_compiz_check_.* certification-status=blocker
16 graphics/2_rotation_.* certification-status=blocker
17- graphics/2_display_.* certification-status=blocker
18+ graphics/2_video_.* certification-status=blocker
19 graphics/2_minimum_resolution_.*
20 graphics/2_cycle_resolution_.*
21 monitor/2_powersaving_.* certification-status=blocker
22
23=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert-12-04-4.whitelist'
24--- providers/plainbox-provider-certification-client/whitelists/client-cert-12-04-4.whitelist 2014-11-21 07:18:17 +0000
25+++ providers/plainbox-provider-certification-client/whitelists/client-cert-12-04-4.whitelist 2015-05-18 06:30:53 +0000
26@@ -80,7 +80,7 @@
27 graphics/driver_version
28 graphics/compiz_check
29 graphics/rotation
30-graphics/display
31+graphics/video
32 graphics/minimum_resolution
33 graphics/xorg-failsafe
34 graphics/xorg-process
35
36=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist'
37--- providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-05-14 19:32:33 +0000
38+++ providers/plainbox-provider-certification-client/whitelists/client-cert.whitelist 2015-05-18 06:30:53 +0000
39@@ -115,7 +115,7 @@
40 graphics/1_driver_version_.*
41 graphics/1_compiz_check_.*
42 graphics/1_rotation_.*
43-graphics/1_display_.*
44+graphics/1_video_.*
45 graphics/1_minimum_resolution_.*
46 graphics/1_cycle_resolution_.*
47 graphics/2_switch_card_.*
48@@ -124,7 +124,7 @@
49 graphics/2_driver_version_.*
50 graphics/2_compiz_check_.*
51 graphics/2_rotation_.*
52-graphics/2_display_.*
53+graphics/2_video_.*
54 graphics/2_minimum_resolution_.*
55 graphics/2_cycle_resolution_.*
56 monitor/2_powersaving_.*
57
58=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-12-04-4.whitelist'
59--- providers/plainbox-provider-certification-client/whitelists/client-selftest-12-04-4.whitelist 2014-11-21 07:18:17 +0000
60+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-12-04-4.whitelist 2015-05-18 06:30:53 +0000
61@@ -77,7 +77,7 @@
62 graphics/driver_version
63 graphics/compiz_check
64 graphics/rotation
65-graphics/display
66+graphics/video
67 graphics/minimum_resolution
68 graphics/xorg-failsafe
69 graphics/xorg-process
70
71=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist'
72--- providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2015-05-14 19:32:33 +0000
73+++ providers/plainbox-provider-certification-client/whitelists/client-selftest-14-04.whitelist 2015-05-18 06:30:53 +0000
74@@ -84,7 +84,7 @@
75 graphics/1_driver_version_.*
76 graphics/1_compiz_check_.*
77 graphics/1_rotation_.*
78-graphics/1_display_.*
79+graphics/1_video_.*
80 graphics/1_minimum_resolution_.*
81 graphics/xorg-failsafe
82 graphics/xorg-process
83@@ -96,7 +96,7 @@
84 graphics/2_driver_version_.*
85 graphics/2_compiz_check_.*
86 graphics/2_rotation_.*
87-graphics/2_display_.*
88+graphics/2_video_.*
89 graphics/2_minimum_resolution_.*
90 graphics/2_cycle_resolution_.*
91 __hibernate__
92
93=== modified file 'providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist'
94--- providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2015-05-14 19:32:33 +0000
95+++ providers/plainbox-provider-certification-client/whitelists/client-selftest.whitelist 2015-05-18 06:30:53 +0000
96@@ -84,7 +84,7 @@
97 graphics/1_driver_version_.*
98 graphics/1_compiz_check_.*
99 graphics/1_rotation_.*
100-graphics/1_display_.*
101+graphics/1_video_.*
102 graphics/1_minimum_resolution_.*
103 graphics/xorg-failsafe
104 graphics/xorg-process
105@@ -96,7 +96,7 @@
106 graphics/2_driver_version_.*
107 graphics/2_compiz_check_.*
108 graphics/2_rotation_.*
109-graphics/2_display_.*
110+graphics/2_video_.*
111 graphics/2_minimum_resolution_.*
112 graphics/2_cycle_resolution_.*
113 __hibernate__
114
115=== modified file 'providers/plainbox-provider-checkbox/jobs/graphics.txt.in'
116--- providers/plainbox-provider-checkbox/jobs/graphics.txt.in 2015-04-28 06:43:55 +0000
117+++ providers/plainbox-provider-checkbox/jobs/graphics.txt.in 2015-05-18 06:30:53 +0000
118@@ -221,14 +221,14 @@
119 _summary: Test graphic memory info for $product.
120 EOF
121
122-id: graphics/generator_display
123+id: graphics/generator_video
124 requires: device.category == 'VIDEO'
125-_description: Display test
126-_summary: Display test
127+_description: Display video test
128+_summary: Display video test
129 plugin: local
130 command:
131 cat <<'EOF' | run_templates -t -s 'graphics_card_resource'
132- id: graphics/`echo ${index}`_display_`echo "${product}" | sed 's/ /_/g;s/[^_a-zA-Z0-9-]//g'`
133+ id: graphics/`echo ${index}`_video_`echo "${product}" | sed 's/ /_/g;s/[^_a-zA-Z0-9-]//g'`
134 plugin: user-interact-verify
135 requires:
136 package.name == 'xorg'
137@@ -237,7 +237,7 @@
138 _summary: Test that video can be displayed with ${product}
139 _description:
140 PURPOSE:
141- This test will test the default display
142+ This test will test the default display with a sample video
143 STEPS:
144 1. Click "Test" to display a video test.
145 VERIFICATION:
146
147=== modified file 'providers/plainbox-provider-checkbox/whitelists/default.whitelist'
148--- providers/plainbox-provider-checkbox/whitelists/default.whitelist 2014-04-25 22:38:44 +0000
149+++ providers/plainbox-provider-checkbox/whitelists/default.whitelist 2015-05-18 06:30:53 +0000
150@@ -49,7 +49,7 @@
151 __graphics__
152 graphics/generator_.*
153 graphics/1_compiz_check.*
154-graphics/display
155+graphics/video
156 graphics/1_resolution.*
157 graphics/1_minimum_resolution.*
158 graphics/1_driver_version.*

Subscribers

People subscribed via source and target branches