Merge lp:~cypressyew/checkbox/dependency-fix into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3707
Merged at revision: 3707
Proposed branch: lp:~cypressyew/checkbox/dependency-fix
Merge into: lp:checkbox
Diff against target: 25 lines (+2/-2)
2 files modified
providers/plainbox-provider-checkbox/jobs/esata.txt.in (+1/-1)
providers/plainbox-provider-checkbox/jobs/firewire.txt.in (+1/-1)
To merge this branch: bzr merge lp:~cypressyew/checkbox/dependency-fix
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Po-Hsu Lin Needs Resubmitting
Review via email: mp+256641@code.launchpad.net

Description of the change

Change the dependency for esata / firewire remove job from storage job to insert job

To post a comment you must log in.
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Resubmit with more information in the commit message.

The reason for this change is that if the storage test failed, the removal test will be skipped automatically. For the tool we have now, we're unable to re-run those automatically skipped tests.

Also, we could still do the removal test even if it failed with the storage test.

review: Needs Resubmitting
3707. By Po-Hsu Lin

provider:checkbox: change the esata/firewire remove job dependency.

Make the esata/firewire remove job depends on the insert job,
so that we could still test it even it failed with the storage test

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/jobs/esata.txt.in'
2--- providers/plainbox-provider-checkbox/jobs/esata.txt.in 2014-05-09 16:53:32 +0000
3+++ providers/plainbox-provider-checkbox/jobs/esata.txt.in 2015-04-17 10:37:51 +0000
4@@ -23,7 +23,7 @@
5
6 plugin: user-interact
7 id: esata/remove
8-depends: esata/storage-test
9+depends: esata/insert
10 command: removable_storage_watcher remove ata_serial_esata
11 _description:
12 PURPOSE:
13
14=== modified file 'providers/plainbox-provider-checkbox/jobs/firewire.txt.in'
15--- providers/plainbox-provider-checkbox/jobs/firewire.txt.in 2014-06-17 17:11:27 +0000
16+++ providers/plainbox-provider-checkbox/jobs/firewire.txt.in 2015-04-17 10:37:51 +0000
17@@ -25,7 +25,7 @@
18
19 plugin: user-interact
20 id: firewire/remove
21-depends: firewire/storage-test
22+depends: firewire/insert
23 require: device.category == 'FIREWIRE'
24 command: removable_storage_watcher remove firewire
25 _description:

Subscribers

People subscribed via source and target branches