Merge lp:~cypressyew/checkbox/cbt-i18n into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Po-Hsu Lin
Approved revision: 4353
Merged at revision: 4358
Proposed branch: lp:~cypressyew/checkbox/cbt-i18n
Merge into: lp:checkbox
Diff against target: 99 lines (+12/-9)
4 files modified
checkbox-touch/checkbox-touch.qml (+3/-3)
checkbox-touch/components/CheckboxTouchApplication.qml (+1/-1)
checkbox-touch/components/ResultsPage.qml (+7/-4)
checkbox-touch/components/ResumeSessionPage.qml (+1/-1)
To merge this branch: bzr merge lp:~cypressyew/checkbox/cbt-i18n
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+295013@code.launchpad.net

Description of the change

Remove extra space, and some minor typo correction.
Regroup strings with arg() to make it more complete to translators.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Goodies! +1, Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/checkbox-touch.qml'
2--- checkbox-touch/checkbox-touch.qml 2016-02-17 09:31:44 +0000
3+++ checkbox-touch/checkbox-touch.qml 2016-05-18 07:23:38 +0000
4@@ -281,7 +281,7 @@
5 onRerunLast: app.resumeSession(true, processNextTest)
6 onContinueSession: app.resumeSession(false, processNextTest)
7 resumeText: i18n.tr("Checkbox session got suspended.\nDo you want \
8- to rerun last test, continue to the next test, or start a new session?")
9+to rerun last test, continue to the next test, or start a new session?")
10 onRestartSession: {
11 pageStack.clear();
12 pageStack.push(welcomePage);
13@@ -435,7 +435,7 @@
14 function createPage(url, test) {
15 var pageComponent = Qt.createComponent(Qt.resolvedUrl(url));
16 if (pageComponent.status == Component.Error) {
17- var msg = i18n.tr("Could not create component '") + url + "'\n" + pageComponent.errorString();
18+ var msg = i18n.tr("Could not create component '%1'\n").arg(url) + pageComponent.errorString();
19 console.error(msg);
20 ErrorLogic.showError(mainView, msg, Qt.quit, i18n.tr("Quit"));
21 } else {
22@@ -573,7 +573,7 @@
23 }
24 CbtDialogLogic.showDialog(
25 resultsPage,
26- i18n.tr("Report has been submited.\n" + s),
27+ i18n.tr("Report has been submitted.\n" + s),
28 [{"text": i18n.tr("OK"), "color": UbuntuColors.green}]);
29 },
30 function(error) {
31
32=== modified file 'checkbox-touch/components/CheckboxTouchApplication.qml'
33--- checkbox-touch/components/CheckboxTouchApplication.qml 2016-02-17 09:31:44 +0000
34+++ checkbox-touch/components/CheckboxTouchApplication.qml 2016-05-18 07:23:38 +0000
35@@ -52,7 +52,7 @@
36 }, function(error) {
37 console.error("Unable to start session: " + error);
38 ErrorLogic.showError(mainView,
39- i18n.tr("Could not start a session. Reason:\n" + error),
40+ i18n.tr("Could not start a session. Reason:\n" + error),
41 Qt.quit,
42 i18n.tr("Quit"));
43 });
44
45=== modified file 'checkbox-touch/components/ResultsPage.qml'
46--- checkbox-touch/components/ResultsPage.qml 2015-11-16 10:20:39 +0000
47+++ checkbox-touch/components/ResultsPage.qml 2016-05-18 07:23:38 +0000
48@@ -132,7 +132,8 @@
49 }
50 Text {
51 objectName: "passedLabel"
52- text: results.totalPassed + " " + i18n.tr("tests passed")
53+ // TRANSLATORS: %1 will be a number, please do not translate it
54+ text: i18n.tr("%1 tests passed").arg(results.totalPassed)
55 }
56 }
57 Row {
58@@ -143,7 +144,8 @@
59 }
60 Text {
61 objectName: "failedLabel"
62- text: results.totalFailed + " " + i18n.tr("tests failed")
63+ // TRANSLATORS: %1 will be a number, please do not translate it
64+ text: i18n.tr("%1 tests failed").arg(results.totalFailed)
65 }
66 }
67 Row {
68@@ -154,7 +156,8 @@
69 }
70 Text {
71 objectName: "skippedLabel"
72- text: results.totalSkipped + " " + i18n.tr("tests skipped")
73+ // TRANSLATORS: %1 will be a number, please do not translate it
74+ text: i18n.tr("%1 tests skipped").arg(results.totalSkipped)
75 }
76 }
77 }
78@@ -174,7 +177,7 @@
79 unlatchedColor: UbuntuColors.green
80 visible: submissionName
81 Layout.fillWidth: true
82- // TRANSLATORS: follwing string will be followed by a service name, e.g. "certification website"
83+ // TRANSLATORS: following string will be followed by a service name, e.g. "certification website"
84 text: i18n.tr("Submit results to " + submissionName)
85 onLatchedClicked: {
86 rerunAction.enabled = false;
87
88=== modified file 'checkbox-touch/components/ResumeSessionPage.qml'
89--- checkbox-touch/components/ResumeSessionPage.qml 2016-01-06 20:21:32 +0000
90+++ checkbox-touch/components/ResumeSessionPage.qml 2016-05-18 07:23:38 +0000
91@@ -71,7 +71,7 @@
92 id: deleteIncompleteButton
93 objectName: "deleteIncompleteButton"
94 visible: incompleteSessionCount > 0
95- text: i18n.tr("Delete incomplete sessions (%0)".arg(incompleteSessionCount))
96+ text: i18n.tr("Delete incomplete sessions (%0)").arg(incompleteSessionCount)
97 unlatchedColor: UbuntuColors.red
98 Layout.fillWidth: true
99 onLatchedClicked: {

Subscribers

People subscribed via source and target branches