Merge lp:~cypressyew/checkbox/add-tb-monitor-generator into lp:checkbox

Proposed by Po-Hsu Lin
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 3789
Merged at revision: 3793
Proposed branch: lp:~cypressyew/checkbox/add-tb-monitor-generator
Merge into: lp:checkbox
Diff against target: 47 lines (+23/-17)
1 file modified
providers/plainbox-provider-checkbox/jobs/monitor.txt.in (+23/-17)
To merge this branch: bzr merge lp:~cypressyew/checkbox/add-tb-monitor-generator
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+259473@code.launchpad.net

Description of the change

Add the missing Thunderbolt monitor generator.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I was looking for the thunderbolt generator in the whitelist but hopefully we get it with monitor/generator_.*

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/jobs/monitor.txt.in'
2--- providers/plainbox-provider-checkbox/jobs/monitor.txt.in 2015-04-23 04:20:19 +0000
3+++ providers/plainbox-provider-checkbox/jobs/monitor.txt.in 2015-05-19 07:10:36 +0000
4@@ -175,20 +175,26 @@
5 Was your screen dimmed approximately to half of the maximum brightness?
6 EOF
7
8-plugin: manual
9-id: monitor/thunderbolt
10-imports: from 2013.com.canonical.plainbox import manifest
11-requires: manifest.has_thunderbolt == 'True'
12-_summary: Display connected via Thunderbolt
13-_description:
14- PURPOSE:
15- This test will check your Thunderbolt port as a monitor interconnect.
16- STEPS:
17- 1. Connect a display (if not already connected) to the Thunderbolt port on
18- your system
19- 2. Switch display modes between in your Display Settings, check if it can be
20- set to mirrored, extended, displayed on external or onboard only
21- VERIFICATION:
22- Was the desktop displayed correctly on the Thunderbolt-connected screen in
23- every mode?
24-
25+id: monitor/generator_thunderbolt
26+_description: Thunderbolt monitor test
27+_summary: Thunderbolt monitor test
28+plugin: local
29+command:
30+ cat <<'EOF' | run_templates -t -s 'graphics_card_resource'
31+ id: monitor/`echo ${index}`_thunderbolt_`echo "${product}" | sed 's/ /_/g;s/[^_a-zA-Z0-9-]//g'`
32+ imports: from 2013.com.canonical.plainbox import manifest
33+ requires: manifest.has_thunderbolt == 'True'
34+ plugin: manual
35+ _summary: Display connected via Thunderbolt for $product
36+ _description:
37+ PURPOSE:
38+ This test will check your Thunderbolt port as a monitor interconnect for $product.
39+ STEPS:
40+ 1. Connect a display (if not already connected) to the Thunderbolt port on
41+ your system
42+ 2. Switch display modes between in your Display Settings, check if it can be
43+ set to mirrored, extended, displayed on external or onboard only
44+ VERIFICATION:
45+ Was the desktop displayed correctly with $product on the Thunderbolt-connected
46+ screen in every mode?
47+ EOF

Subscribers

People subscribed via source and target branches