Merge lp:~cypressyew/checkbox/DisconnectMobileBB into lp:checkbox

[Po-Hsu Lin]

Disconnect from the mobile broadband network after the test is complete,
it will disconnect only if it's connected.

On second thought, there is a potential problem is that those who are primarily using the mobile broadband network may not want this feature because their network will be disconnected.
But I think maybe it's still a reasonable idea, especially for lab testers.

[Daniel Manrique (roadmr)]

Looks OK, the main use case for this test is lab and certification testing under controlled situations.

Thanks!

review: Approve

[Daniel Manrique (roadmr)]

The attempt to merge lp:~cypressyew/checkbox/DisconnectMobileBB into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] (timing) 7.46user 3.71system 3:33.09elapsed 5%CPU (0avgtext+0avgdata 22128maxresident)k
[precise] (timing) 0inputs+128outputs (0major+183000minor)pagefaults 0swaps
[precise] Starting tests...
[precise] CheckBox test suite: PASS
[precise] (timing) 0.80user 0.31system 0:38.54elapsed 2%CPU (0avgtext+0avgdata 19904maxresident)k
[precise] (timing) 8inputs+32outputs (0major+47415minor)pagefaults 0swaps
[precise] (timing) 0.77user 0.26system 0:05.63elapsed 18%CPU (0avgtext+0avgdata 20448maxresident)k
[precise] (timing) 0inputs+16outputs (0major+47563minor)pagefaults 0swaps
[precise] PlainBox test suite: PASS
[precise] (timing) 1.01user 0.27system 0:12.82elapsed 10%CPU (0avgtext+0avgdata 19932maxresident)k
[precise] (timing) 0inputs+192outputs (0major+47538minor)pagefaults 0swaps
[precise] PlainBox documentation build: PASS
[precise] (timing) 0.83user 0.24system 0:19.30elapsed 5%CPU (0avgtext+0avgdata 20348maxresident)k
[precise] (timing) 0inputs+16outputs (0major+47483minor)pagefaults 0swaps
[precise] CheckBoxNG test suite: PASS
[precise] (timing) 0.80user 0.24system 0:06.54elapsed 15%CPU (0avgtext+0avgdata 20628maxresident)k
[precise] (timing) 0inputs+16outputs (0major+47407minor)pagefaults 0swaps
[precise] Integration tests: PASS
[precise] (timing) 0.77user 0.28system 0:06.96elapsed 15%CPU (0avgtext+0avgdata 20176maxresident)k
[precise] (timing) 0inputs+8outputs (0major+47410minor)pagefaults 0swaps
[precise] Destroying VM
[quantal] Bringing VM 'up'
[quantal] Unable to 'up' VM!
[quantal] stdout: http://paste.ubuntu.com/5936801/
[quantal] stderr: http://paste.ubuntu.com/5936802/
[quantal] NOTE: unable to execute tests, marked as failed
[quantal] Destroying failed VM to reclaim resources
[quantal] Forcing shutdown of VM...
[quantal] Destroying VM and associated drives...
[raring] Bringing VM 'up'
[raring] (timing) 8.18user 3.50system 2:34.99elapsed 7%CPU (0avgtext+0avgdata 21564maxresident)k
[raring] (timing) 0inputs+152outputs (0major+217307minor)pagefaults 0swaps
[raring] Starting tests...
[raring] CheckBox test suite: PASS
[raring] (timing) 0.86user 0.27system 0:38.77elapsed 2%CPU (0avgtext+0avgdata 20728maxresident)k
[raring] (timing) 0inputs+40outputs (0major+49350minor)pagefaults 0swaps
[raring] (timing) 0.74user 0.28system 0:06.79elapsed 15%CPU (0avgtext+0avgdata 20804maxresident)k
[raring] (timing) 0inputs+16outputs (0major+47319minor)pagefaults 0swaps
[raring] PlainBox test suite: PASS
[raring] (timing) 1.01user 0.28system 0:15.69elapsed 8%CPU (0avgtext+0avgdata 19808maxresident)k
[raring] (timing) 0inputs+192outputs (0major+47419minor)pagefaults 0swaps
[raring] PlainBox documentation build: PASS
[raring] (timing) 0.71user 0.38system 0:19.47elapsed 5%CPU (0avgtext+0avgdata 20748maxresident)k
[raring] (timing) 0inputs+16outputs (0major+49355minor)pagefaults 0swaps
[raring] CheckBoxNG test suite: PASS
[raring] (timing) 0.82user 0.22system 0:06.87elapsed...

[Daniel Manrique (roadmr)]

Tarmac barfed, reapproving.

review: Approve

=== modified file 'checkbox-old/debian/changelog'
--- checkbox-old/debian/changelog	2013-07-24 19:14:16 +0000
+++ checkbox-old/debian/changelog	2013-07-26 10:43:24 +0000
@@ -1,5 +1,10 @@
 checkbox (0.16.7) UNRELEASED; urgency=low
 
+  [ Po-Hsu Lin ]
+  * jobs/mobilebroadband.txt.in: Make it disconnect from the mobile broadband
+    network after job is completed to avoid any unexpected data transmission 
+    expense (LP: #1204799)
+
   [ Jeff Lane ]
   * jobs/suspend.txt.in, jobs/usb.txt.in, jobs/mediacard.txt.in: moved jobs to
     suspend.txt.in for USB and Mediacard after suspend, renamed jobs

=== modified file 'checkbox-old/jobs/mobilebroadband.txt.in'
--- checkbox-old/jobs/mobilebroadband.txt.in	2013-05-29 07:50:30 +0000
+++ checkbox-old/jobs/mobilebroadband.txt.in	2013-07-26 10:43:24 +0000
@@ -6,8 +6,8 @@
     mobilebroadband.gsm == 'supported'
 user: root
 environ: GSM_CONN_NAME GSM_APN GSM_USERNAME GSM_PASSWORD
-command: trap "nmcli con delete id $GSM_CONN_NAME" EXIT; create_connection mobilebroadband gsm `if [ ${GSM_APN} ]; then echo "--apn=$GSM_APN"; fi` `if [ ${GSM_CONN_NAME} ]; then echo "--name=$GSM_CONN_NAME"; fi` `if [ ${GSM_USERNAME} ]; then echo "--username=$GSM_USERNAME"; fi` `if [ ${GSM_PASSWORD} ]; then echo "--password=$GSM_PASSWORD"; fi` && curl http://start.ubuntu.com/connectivity-check.html --interface `nmcli dev status | awk '/gsm/ {print $1}'`
-_description: Creates a mobile broadband connection for a GSM based modem and checks the connection to ensure it's working.
+command: trap "nmcli con delete id $GSM_CONN_NAME" EXIT; create_connection mobilebroadband gsm `if [ ${GSM_APN} ]; then echo "--apn=$GSM_APN"; fi` `if [ ${GSM_CONN_NAME} ]; then echo "--name=$GSM_CONN_NAME"; fi` `if [ ${GSM_USERNAME} ]; then echo "--username=$GSM_USERNAME"; fi` `if [ ${GSM_PASSWORD} ]; then echo "--password=$GSM_PASSWORD"; fi` && curl http://start.ubuntu.com/connectivity-check.html --interface `nmcli dev status | awk '/gsm/ {print $1}'`; if [ "`nmcli dev status | awk '/gsm/ {print $3}'`" == "connected" ]; then nmcli con down id `[ ${GSM_CONN_NAME} ] && echo "$GSM_CONN_NAME" || echo "MobileBB"`; fi
+_description: Creates a mobile broadband connection for a GSM based modem and checks the connection to ensure it's working. 
 
 plugin: shell
 name: mobilebroadband/cdma_connection
@@ -17,5 +17,5 @@
     mobilebroadband.cdma == 'supported'
 user: root
 environ: CDMA_CONN_NAME CDMA_USERNAME CDMA_PASSWORD
-command: trap "nmcli con delete id $CDMA_CONN_NAME" EXIT; create_connection mobilebroadband cdma `if [ ${CDMA_CONN_NAME} ]; then echo "--name=$CDMA_CONN_NAME"; fi` `if [ ${CDMA_USERNAME} ]; then echo "--username=$CDMA_USERNAME"; fi` `if [ ${CDMA_PASSWORD} ]; then echo "--password=$CDMA_PASSWORD"; fi` && curl http://start.ubuntu.com/connectivity-check.html --interface `nmcli dev status | awk '/gsm/ {print $1}'`
+command: trap "nmcli con delete id $CDMA_CONN_NAME" EXIT; create_connection mobilebroadband cdma `if [ ${CDMA_CONN_NAME} ]; then echo "--name=$CDMA_CONN_NAME"; fi` `if [ ${CDMA_USERNAME} ]; then echo "--username=$CDMA_USERNAME"; fi` `if [ ${CDMA_PASSWORD} ]; then echo "--password=$CDMA_PASSWORD"; fi` && curl http://start.ubuntu.com/connectivity-check.html --interface `nmcli dev status | awk '/gsm/ {print $1}'`; if [ "`nmcli dev status | awk '/gsm/ {print $3}'`" == "connected" ]; then nmcli con down id `[ ${CDMA_CONN_NAME} ] && echo "$CDMA_CONN_NAME" || echo "MobileBB"`; fi
 _description: Creates a mobile broadband connection for a CDMA based modem and checks the connection to ensure it's working.