Merge lp:~cyphermox/ubuntu-system-settings/lp1382767 into lp:ubuntu-system-settings

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 1143
Merged at revision: 1165
Proposed branch: lp:~cyphermox/ubuntu-system-settings/lp1382767
Merge into: lp:ubuntu-system-settings
Diff against target: 40 lines (+11/-2)
2 files modified
plugins/bluetooth/PageComponent.qml (+9/-2)
plugins/bluetooth/devicemodel.cpp (+2/-0)
To merge this branch: bzr merge lp:~cyphermox/ubuntu-system-settings/lp1382767
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+239066@code.launchpad.net

Commit message

[bluetooth] Show bluetooth address instead of name while it's not detected; to be updated once available.

Description of the change

[bluetooth] Show bluetooth address instead of name while it's not detected; to be updated once available.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1143
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mathieu-tl/ubuntu-system-settings/lp1382767/+merge/239066/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1668/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6103
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4158
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/860
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5731
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7355
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7355/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14911
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3519
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4503
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4503/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1668/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

looks fine to me, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/bluetooth/PageComponent.qml'
2--- plugins/bluetooth/PageComponent.qml 2014-09-23 19:32:29 +0000
3+++ plugins/bluetooth/PageComponent.qml 2014-10-21 14:20:22 +0000
4@@ -323,7 +323,11 @@
5
6 Page {
7 id: connectedDevicePage
8- title: backend.selectedDevice ? backend.selectedDevice.name : i18n.tr("None")
9+ title: backend.selectedDevice ?
10+ backend.selectedDevice.name.length > 0 ?
11+ backend.selectedDevice.name :
12+ backend.selectedDevice.address
13+ : i18n.tr("None")
14 visible: false
15
16 Flickable {
17@@ -344,7 +348,10 @@
18
19 ListItem.SingleValue {
20 text: i18n.tr("Name")
21- value: backend.selectedDevice ? backend.selectedDevice.name : i18n.tr("None")
22+ value: backend.selectedDevice &&
23+ backend.selectedDevice.name.length > 0 ?
24+ backend.selectedDevice.name :
25+ i18n.tr("None")
26 }
27 ListItem.Standard {
28 Rectangle {
29
30=== modified file 'plugins/bluetooth/devicemodel.cpp'
31--- plugins/bluetooth/devicemodel.cpp 2014-09-16 19:41:44 +0000
32+++ plugins/bluetooth/devicemodel.cpp 2014-10-21 14:20:22 +0000
33@@ -382,6 +382,8 @@
34 if (device->isValid()) {
35 addDevice(device);
36 }
37+ } else {
38+ device->setProperties(properties);
39 }
40 }
41

Subscribers

People subscribed via source and target branches