Merge lp:~cyphermox/ubuntu-archive-tools/component-mismatches-mir into lp:ubuntu-archive-tools
Proposed by
Mathieu Trudel-Lapierre
Status: | Merged |
---|---|
Approved by: | Łukasz Zemczak |
Approved revision: | 1162 |
Merged at revision: | 1160 |
Proposed branch: | lp:~cyphermox/ubuntu-archive-tools/component-mismatches-mir |
Merge into: | lp:ubuntu-archive-tools |
Diff against target: |
62 lines (+13/-7) 1 file modified
component-mismatches (+13/-7) |
To merge this branch: | bzr merge lp:~cyphermox/ubuntu-archive-tools/component-mismatches-mir |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak | code review | Approve | |
Review via email: mp+340939@code.launchpad.net |
Description of the change
Add assignee if a MIR bug is currently open and not yet approved (Fix Committed or Fix Released). This helps quickly parsing the component mismatches for the rough status of a MIR bug, if it's yet to be looked at or already been reviewed by a MIR team member and waiting for a security code-review.
To post a comment you must log in.
Looks good, there's one small nitpick but I guess we could just ignore it. In line 810 there's a comment regarding get_mir_bugs():
Return a map source -> [(id, status, title), ...]
So it would be nice if the assignee was added there for consistency. But as I said, this is a nitpick and otherwise it's all good code-wise.