Merge lp:~cyphermox/pasaffe/password-length into lp:~mdeslaur/pasaffe/trunk

[Mathieu Trudel-Lapierre]

I'd really personally much rather not reduce password complexity on my systems. I've been using 20 characters now for a little while, grew accustomed to it, and given that the passwords generated by apg are pronounceable, only sometimes include special characters, I'd rather them be longer.

In all; I think the option should be given to users anyway, so this branch adds the necessary UI control and pieces of code to support changing the value.

[Marc Deslauriers (mdeslaur)]

The generated password used to be variable, between 8 and 12 characters. This changes the maximum, but leaves the minimum in place.

Since we're now exposing it in the GUI, perhaps we should make it a fixed number instead of having a variable length?

[Mathieu Trudel-Lapierre (cyphermox)]

On Wed, Jul 11, 2012 at 7:46 AM, Marc Deslauriers
<email address hidden> wrote:
> The generated password used to be variable, between 8 and 12 characters. This changes the maximum, but leaves the minimum in place.
>
> Since we're now exposing it in the GUI, perhaps we should make it a fixed number instead of having a variable length?

Ah, that explains the weird shorter passwords I'd see ;)

Yes, I think we should. I think people are free to remove a few
characters from a generated password if they're size-limited by
whatever password policy websites or services enforce.

Mathieu Trudel-Lapierre <email address hidden>
Freenode: cyphermox, Jabber: <email address hidden>
4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93

[Marc Deslauriers (mdeslaur)]

Thanks for the patch, ACK!

review: Approve

=== modified file 'data/apps.pasaffe.gschema.xml'
--- data/apps.pasaffe.gschema.xml	2012-02-04 21:45:53 +0000
+++ data/apps.pasaffe.gschema.xml	2012-07-11 02:45:21 +0000
@@ -31,5 +31,10 @@
       <summary>Automatically save changes</summary>
       <description>When this is true, Pasaffe will automatically save the database.</description>
     </key>
+    <key name="password-length" type="i">
+      <default>12</default>
+      <summary>Length of generated passwords</summary>
+      <description>Number of characters to generate for random passwords.</description>
+    </key>
   </schema>
 </schemalist>

=== modified file 'data/ui/PreferencesPasaffeDialog.ui'
--- data/ui/PreferencesPasaffeDialog.ui	2011-09-27 06:58:19 +0000
+++ data/ui/PreferencesPasaffeDialog.ui	2012-07-11 02:45:21 +0000
@@ -7,6 +7,11 @@
     <property name="step_increment">1</property>
     <property name="page_increment">10</property>
   </object>
+  <object class="GtkAdjustment" id="adjustment2">
+    <property name="upper">100</property>
+    <property name="step_increment">1</property>
+    <property name="page_increment">10</property>
+  </object>
   <object class="PreferencesPasaffeDialog" id="preferences_pasaffe_dialog">
     <property name="can_focus">False</property>
     <property name="border_width">5</property>
@@ -107,6 +112,45 @@
               </packing>
             </child>
             <child>
+              <object class="GtkHBox" id="hbox2">
+                <property name="visible">True</property>
+                <property name="can_focus">False</property>
+                <child>
+                  <object class="GtkLabel" id="password-length-label">
+                    <property name="visible">True</property>
+                    <property name="can_focus">False</property>
+                    <property name="label" translatable="yes">Password length (characters)</property>
+                  </object>
+                  <packing>
+                    <property name="expand">True</property>
+                    <property name="fill">True</property>
+                    <property name="position">0</property>
+                  </packing>
+                </child>
+                <child>
+                  <object class="GtkSpinButton" id="password-length">
+                    <property name="visible">True</property>
+                    <property name="can_focus">True</property>
+                    <property name="invisible_char">•</property>
+                    <property name="invisible_char_set">True</property>
+                    <property name="primary_icon_activatable">False</property>
+                    <property name="secondary_icon_activatable">False</property>
+                    <property name="adjustment">adjustment2</property>
+                    <property name="numeric">True</property>
+                  </object>
+                  <packing>
+                    <property name="expand">True</property>
+                    <property name="fill">True</property>
+                    <property name="position">1</property>
+                  </packing>
+                </child>
+              </object>
+              <packing>
+                <property name="top_attach">4</property>
+                <property name="bottom_attach">5</property>
+              </packing>
+            </child>
+            <child>
               <object class="GtkCheckButton" id="auto-save">
                 <property name="label" translatable="yes">Automatically save changes</property>
                 <property name="visible">True</property>
@@ -117,8 +161,8 @@
                 <property name="draw_indicator">True</property>
               </object>
               <packing>
-                <property name="top_attach">4</property>
-                <property name="bottom_attach">5</property>
+                <property name="top_attach">5</property>
+                <property name="bottom_attach">6</property>
               </packing>
             </child>
           </object>

=== modified file 'pasaffe/EditDetailsDialog.py'
--- pasaffe/EditDetailsDialog.py	2012-04-29 17:19:29 +0000
+++ pasaffe/EditDetailsDialog.py	2012-07-11 02:45:21 +0000
@@ -14,7 +14,7 @@
 # with this program.  If not, see <http://www.gnu.org/licenses/>.
 ### END LICENSE
 
-from gi.repository import Gtk # pylint: disable=E0611
+from gi.repository import Gio, Gtk # pylint: disable=E0611
 
 from pasaffe_lib.helpers import get_builder
 
@@ -50,6 +50,9 @@
         self.builder = builder
         self.ui = builder.get_ui(self)
 
+        settings = Gio.Settings("apps.pasaffe")
+        self.password_length = settings.get_int("password-length")
+
     def on_btn_ok_clicked(self, widget, data=None):
         """The user has elected to save the changes.
 
@@ -75,7 +78,7 @@
 
     def show_passwords_menu(self):
         """Generate some new passwords"""
-        command = ["apg", "-n", "6", "-M", "sNC", "-m", "8", "-x", "12"]
+        command = ["apg", "-n", "6", "-M", "sNC", "-m", "8", "-x", str(self.password_length)]
         try:
             passwords = subprocess.check_output(command).splitlines()
             self.ui.password1.set_label(passwords[0])

=== modified file 'pasaffe/PreferencesPasaffeDialog.py'
--- pasaffe/PreferencesPasaffeDialog.py	2012-04-29 17:19:29 +0000
+++ pasaffe/PreferencesPasaffeDialog.py	2012-07-11 02:45:21 +0000
@@ -44,5 +44,7 @@
         settings.bind("idle-timeout", widget, "value", Gio.SettingsBindFlags.DEFAULT)
         widget = self.builder.get_object('auto-save')
         settings.bind("auto-save", widget, "active", Gio.SettingsBindFlags.DEFAULT)
+        widget = self.builder.get_object('password-length')
+        settings.bind("password-length", widget, "value", Gio.SettingsBindFlags.DEFAULT)
 
         # Code for other initialization actions should be added here.