indicator-power

Merge lp:~cyphermox/indicator-power/pthread-linking into lp:indicator-power/13.04

  1. pthread-linking
  2. Merge into trunk.13.04
Proposed by Mathieu Trudel-Lapierre
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 166
Merged at revision: 166
Proposed branch: lp:~cyphermox/indicator-power/pthread-linking
Merge into: lp:indicator-power/13.04
Diff against target: 11 lines (+1/-0)
1 file modified
tests/Makefile.am (+1/-0)
To merge this branch: bzr merge lp:~cyphermox/indicator-power/pthread-linking
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+151787@code.launchpad.net

Commit message

Do the linking with -lpthread correctly.

Description of the change

Do the linking with -lpthread correctly.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/28/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=coverity-raring,flavor=armhf/28/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=armhf/28/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=i386/28/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=armhf/28//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=i386/28//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/28//rebuild/?

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/29/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=armhf/29/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=i386/29/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/29//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=armhf/29//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/indicator-power-ci/./build=pbuilder,distribution=raring,flavor=i386/29//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/29//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

looking good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/Makefile.am'
2--- tests/Makefile.am 2013-01-22 20:00:25 +0000
3+++ tests/Makefile.am 2013-03-05 15:38:30 +0000
4@@ -27,6 +27,7 @@
5 $(INDICATOR_LIBS) \
6 $(UPOWER_LIBS) \
7 $(COVERAGE_LDFLAGS) \
8+ $(XORG_GTEST_LDFLAGS) \
9 libgtest.a
10
11 TEST_CPPFLAGS = \

Subscribers

People subscribed via source and target branches