Merge lp:~cyphermox/evolution-indicator/url-source into lp:evolution-indicator

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 80
Proposed branch: lp:~cyphermox/evolution-indicator/url-source
Merge into: lp:evolution-indicator
Diff against target: 50 lines (+9/-5)
1 file modified
src/evolution-indicator.c (+9/-5)
To merge this branch: bzr merge lp:~cyphermox/evolution-indicator/url-source
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+66213@code.launchpad.net

Description of the change

Fix URL retrieval after evo got updated to past 3.0.2. Evo API changes and no longer directly exposes the URL of the account store.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/evolution-indicator.c'
2--- src/evolution-indicator.c 2011-05-27 10:57:30 +0000
3+++ src/evolution-indicator.c 2011-06-28 22:16:12 +0000
4@@ -227,14 +227,18 @@
5 void
6 org_gnome_mail_new_notify (EPlugin *ep, EMEventTargetFolder *t)
7 {
8- g_return_if_fail (t != NULL);
9+ gchar *url;
10+
11+ g_return_if_fail (t != NULL);
12+
13+ url = camel_service_get_url (CAMEL_SERVICE (t->store));
14
15 if (!t->new)
16 return;
17
18 if (only_inbox && !(t->is_inbox))
19 {
20- g_debug ("EI: %s is not an inbox", t->uri);
21+ g_debug ("EI: %s is not an inbox", url);
22 return;
23 }
24
25@@ -246,7 +250,7 @@
26
27 g_static_mutex_lock (&mlock);
28
29- g_debug ("EI:mail_new_notify: %s", t->uri);
30+ g_debug ("EI:mail_new_notify: %s", url);
31
32 message_count += t->new;
33
34@@ -259,7 +263,7 @@
35 {
36 IndicateIndicator *indi = i->data;
37
38- if (g_strstr_len (t->uri,
39+ if (g_strstr_len (url,
40 -1,
41 indicate_indicator_get_property (indi, "url")))
42 {
43@@ -280,7 +284,7 @@
44 }
45 else
46 {
47- g_warning ("EI: Unable to find account that matches %s", t->uri);
48+ g_warning ("EI: Unable to find account that matches %s", url);
49 }
50 }
51

Subscribers

People subscribed via source and target branches